Add CPURequestsRemoveLimitsMemoryRequestsAndLimits controlled values for DPA#2902
Add CPURequestsRemoveLimitsMemoryRequestsAndLimits controlled values for DPA#2902clamoriniere wants to merge 1 commit intomainfrom
Conversation
…calerContainerControlledValues Introduce a new mixed-mode enum value that applies different strategies per resource type: CPU requests are controlled while any existing CPU limit is removed (to avoid throttling), and memory controls both requests and limits. Also add doc comments to all three enum values to clarify their respective behaviours. Assisted-by: Claude:claude-sonnet-4-6
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 40.05% 40.05%
=======================================
Files 319 319
Lines 28052 28052
=======================================
Hits 11237 11237
Misses 15993 15993
Partials 822 822
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c59fc90bbc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| enum: | ||
| - RequestsAndLimits | ||
| - RequestsOnly | ||
| - CPURequestsRemoveLimitsMemoryRequestsAndLimits |
There was a problem hiding this comment.
Regenerate packaged CRDs for new controlledValues enum
This adds CPURequestsRemoveLimitsMemoryRequestsAndLimits to the source CRD schema, but the distributed CRD artifacts still shipped from this repo (bundle/manifests/datadoghq.com_datadogpodautoscalers.yaml and marketplaces/charts/google-marketplace/chart/datadog-mp/templates/manifests.yaml) still only allow RequestsAndLimits and RequestsOnly. In installs that use those packaged manifests (OLM bundle / marketplace), the new mode will be rejected by CRD validation, so the feature is only partially delivered.
Useful? React with 👍 / 👎.
Summary
CPURequestsRemoveLimitsMemoryRequestsAndLimitsenum value toDatadogPodAutoscalerContainerControlledValuesmake generateTest plan
🤖 Assisted-by: Claude:claude-sonnet-4-6 sparse smatch