Skip to content

Refactor ConfigAPI tests#11487

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
daniel.mohedano/reorganize-config-api-dtos-in-ci-visibility-tests
Jun 1, 2026
Merged

Refactor ConfigAPI tests#11487
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
masterfrom
daniel.mohedano/reorganize-config-api-dtos-in-ci-visibility-tests

Conversation

@daniel-mohedano
Copy link
Copy Markdown
Contributor

@daniel-mohedano daniel-mohedano commented May 28, 2026

What Does This Do

  • Follow-up to Refactor ConfigAPI with new DTO package #11486
  • Migrates existing ConfigApi tests to JUnit
  • Extracts common request/response contract testing to an abstract test
    • Implementation specific validation is kept in each implementation's test (ConfigurationApiImplTest and FileBasedConfigurationApiTest)

Motivation

Continue cleaning up the ConfigApi implementation.

Additional Notes

test-environment-trigger: skip

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: SDTEST-3810

@daniel-mohedano daniel-mohedano added tag: no release notes Changes to exclude from release notes type: refactoring comp: ci visibility Continuous Integration Visibility labels May 28, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.91 s 13.92 s [-1.0%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.86 s 12.95 s [-1.6%; +0.3%] (no difference)
startup:petclinic:appsec:Agent 17.24 s 16.90 s [+0.5%; +3.5%] (maybe worse)
startup:petclinic:iast:Agent 17.07 s 17.15 s [-1.6%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 17.25 s 17.16 s [-0.9%; +2.0%] (no difference)
startup:petclinic:tracing:Agent 16.36 s 16.48 s [-2.3%; +0.8%] (no difference)

Commit: 64a883b8 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-prod-us1-3

This comment has been minimized.

@daniel-mohedano daniel-mohedano changed the title feat: improve configAPI tests Refactor ConfigAPI tests May 28, 2026
@daniel-mohedano daniel-mohedano marked this pull request as ready for review May 28, 2026 14:02
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner May 28, 2026 14:02
Base automatically changed from daniel.mohedano/reorganize-config-api-dtos-in-ci-visibility to master May 28, 2026 15:43
@daniel-mohedano daniel-mohedano force-pushed the daniel.mohedano/reorganize-config-api-dtos-in-ci-visibility-tests branch from cb7d433 to 3a41170 Compare May 29, 2026 09:42
@daniel-mohedano
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 29, 2026

View all feedbacks in Devflow UI.

2026-05-29 12:26:01 UTC ℹ️ Start processing command /merge


2026-05-29 12:26:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-29 14:26:38 UTC 🚨 MergeQueue: This merge request is in error

error while getting head build completion result

Details

Error: There was an error while retrieving the result for pipeline 115881439

FullStacktrace:
child workflow execution error (type: mergequeue_private.MergeQueue_WaitForChecksOrUntilIsFinal, workflowID: 019e73b2-f8a1-7701-9595-360ba87c95fc_74, runID: 019e73b3-5aad-7c6a-a506-86fcfaa7b982, initiatedEventID: 74, startedEventID: 75): child workflow execution error (type: mergequeue.MergeQueue_WaitForCompletionOfRef, workflowID: 019e73b3-5aad-7c6a-a506-86fcfaa7b982_8, runID: 019e73b3-5da7-794d-8633-4658f94771d6, initiatedEventID: 8, startedEventID: 10): There was an error while retrieving the result for pipeline 115881439 (type: FlowError, retryable: false): There was an error while retrieving the result for pipeline 115881439

@daniel-mohedano
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 29, 2026

View all feedbacks in Devflow UI.

2026-05-29 17:18:12 UTC ℹ️ Start processing command /merge


2026-05-29 17:18:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-05-29 19:18:37 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 5770079607981199594 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@daniel-mohedano
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 1, 2026

View all feedbacks in Devflow UI.

2026-06-01 10:58:04 UTC ℹ️ Start processing command /merge


2026-06-01 10:58:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-01 12:17:36 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit f464101 into master Jun 1, 2026
571 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the daniel.mohedano/reorganize-config-api-dtos-in-ci-visibility-tests branch June 1, 2026 12:17
@github-actions github-actions Bot added this to the 1.63.0 milestone Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants