Skip to content

Drop noopScope() wrapper caching from OT/OTel TypeConverters#12011

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/cleanup-noop-scope-wrappers
Jul 21, 2026
Merged

Drop noopScope() wrapper caching from OT/OTel TypeConverters#12011
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
mcculls/cleanup-noop-scope-wrappers

Conversation

@mcculls

@mcculls mcculls commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

The cached noopScopeWrapper only optimized an already-rare path (scope-manager depth-limit overflow); drop the special-casing and the now-unneeded dependency on AgentTracer.noopScope() identity.

Motivation

Further step towards being able to completely remove the noopScope() sentinel

Contributor Checklist

Jira ticket: [PROJ-IDENT]

The cached noopScopeWrapper only optimized an already-rare path
(scope-manager depth-limit overflow); drop the special-casing and
the now-unneeded dependency on AgentTracer.noopScope() identity.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mcculls mcculls added the comp: core Tracer core label Jul 20, 2026
@mcculls
mcculls requested review from a team as code owners July 20, 2026 21:51
@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring labels Jul 20, 2026
@mcculls
mcculls requested review from mtoffl01 and ygree and removed request for a team July 20, 2026 21:51
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Jul 20, 2026

@datadog-prod-us1-5 datadog-prod-us1-5 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

Removing noop scope wrapper caching is safe; the functional contract (scope.span() returns cached noop span wrapper) is preserved. All tests updated to reflect the new behavior correctly. No behavioral regressions detected.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 5975f1a · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 57.27% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5975f1a | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.92 s 13.85 s [-0.2%; +1.2%] (no difference)
startup:insecure-bank:tracing:Agent 12.86 s 13.00 s [-1.8%; -0.4%] (maybe better)
startup:petclinic:appsec:Agent 16.85 s 16.75 s [-0.4%; +1.6%] (no difference)
startup:petclinic:iast:Agent 16.90 s 16.99 s [-1.5%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.71 s 16.64 s [-0.5%; +1.4%] (no difference)
startup:petclinic:sca:Agent 16.59 s 16.88 s [-6.1%; +2.7%] (no difference)
startup:petclinic:tracing:Agent 15.65 s 16.25 s [-7.8%; +0.4%] (no difference)

Commit: 5975f1ae · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@mcculls
mcculls added this pull request to the merge queue Jul 21, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-21 07:18:19 UTC ℹ️ Start processing command /merge


2026-07-21 07:18:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-21 08:07:42 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 3d5c3fb:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@mcculls
mcculls added this pull request to the merge queue Jul 21, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-21 08:12:57 UTC ℹ️ Start processing command /merge


2026-07-21 08:13:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-07-21 09:13:49 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 21, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 01b5e2c into master Jul 21, 2026
593 of 598 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/cleanup-noop-scope-wrappers branch July 21, 2026 09:13
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants