Skip to content

libdatadog update to 42d9ab04#3927

Open
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest
Open

libdatadog update to 42d9ab04#3927
dd-octo-sts[bot] wants to merge 1 commit into
masterfrom
bot/libdatadog-latest

Conversation

@dd-octo-sts
Copy link
Copy Markdown
Contributor

@dd-octo-sts dd-octo-sts Bot commented May 28, 2026

Summary

Automated update of the libdatadog submodule to the latest HEAD.

SHA
Previous cea1e44edddd9124f75d5095f31026904a1f58d8
New 42d9ab0438338516d2e8ef962de4f8ed158c519d

Full CI result: ❌ 35 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/116142462


libdatadog Integration Report

libdatadog SHA: 42d9ab0438338516d2e8ef962de4f8ed158c519d
Analysis date: 2026-05-31

Overall status

❌ Blocking issues remain — but the blocker is CI infrastructure, not a code/API incompatibility. API compatibility against this libdatadog SHA could not be validated, because no job in the pipeline ever reached the Rust compilation stage.

Build & test summary

35 jobs failed across the tracer and package sub-pipelines. They fall into one root cause plus its downstream effects:

  • 33 of 34 traced jobs (all compile profiler extension, compile tracing extension, and compile tracing sidecar variants, every PHP version × arch) failed at the exact same step, in the pre-build script that pins the libdatadog submodule:

    $ (cd libdatadog; git fetch --depth=1 origin "42d9ab0438338516d2e8ef962de4f8ed158c519d" 2>&1)
    fatal: git fetch-pack: expected shallow list
    fatal: The remote end hung up unexpectedly
    ERROR: Job failed: command terminated with exit code 1
    

    The submodule was checked out at its .gitmodules-pinned commit (cea1e44edddd9124f75d5095f31026904a1f58d8), and the subsequent shallow fetch of the target SHA failed at the git wire-protocol level. Compilation never started.

  • 1 traced jobcompile extension: debug: [8.3, arm64] (tracer-trigger) — failed at the final link step:

    ld: warning: cannot find entry symbol ddog_spawn_direct_entry; not setting start address
    cc: error: no such file or directory: 'target/debug/libddtrace_php.a'
    

    The C extension objects compiled and archived fine; the final ddtrace.so link failed because the Rust static library target/debug/libddtrace_php.a was never produced (and with it, the libdatadog-provided entry symbol ddog_spawn_direct_entry). This is the same root cause surfacing downstream: the Rust crate that links libdatadog could not be built.

  • aggregate tested versions failed as a downstream aggregation of the already-failed compile jobs.

A scan of every trace file for Rust compiler diagnostics (error[Exxx], no method named, unresolved import, trait-bound failures, mismatched types, expected struct/enum, renamed paths, etc.) returned no matches. There is no evidence of any API break in these logs — there is also no evidence of compatibility, because the code was never compiled.

Non-trivial changes made

No code changes required.

No dd-trace-php Rust source was edited. The failures contain no API-incompatibility signal to act on, and the project constraints forbid speculative rewrites or working around infrastructure failures in code. Editing call sites based only on the changelog (without a compiler surfacing a concrete break) would risk introducing regressions.

Identified libdatadog issues

None identified.

The git fetch failure (git fetch-pack: expected shallow list / The remote end hung up unexpectedly) is an infrastructure/transient git-server problem on the CI side, not a defect in libdatadog code. It is unrelated to the contents of the new SHA and is expected to clear on a pipeline re-run.

Flaky / ignored failures

All 35 failures are attributable to the single infrastructure root cause above (the libdatadog submodule shallow-fetch failing), and are therefore ignored for the purpose of API-compatibility analysis:

  • 33 × compile profiler extension / compile tracing extension / compile tracing sidecar (all arch/version combos) — git shallow-fetch failure before compilation.
  • 1 × compile extension: debug: [8.3, arm64] — missing libddtrace_php.a (downstream of the same root cause).
  • 1 × aggregate tested versions — downstream aggregation of the failed compile jobs.

Recommendation / caveat

This update is unverified, not clean. The pipeline must be re-run once the git infrastructure recovers so that compilation can actually exercise the new libdatadog API.

Of note, the changelog since the pinned SHA contains several breaking (!) changes that touch FFI/trace surfaces dd-trace-php may consume, and which a real compile run should be checked against:

  • feat!: Align tracer FFI error and response types with common conventions (#2029)
  • fix(crashtracking)!: flatten all threads object into a list of ThreadData (#2054)
  • feat(trace-utils)!: introduce VecMap datastructure (#2022)
  • feat(trace-utils)!: add from_string to span text (#2011)
  • feat!: add encoder from v04 to v1 (#1896)
  • feat: Add FFI for trace exporter (#1952)

These were not validated by this pipeline run and may or may not require adaptation; a successful re-run is the only way to know.


/cc @bwoebi

@dd-octo-sts dd-octo-sts Bot requested a review from a team as a code owner May 28, 2026 02:23
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented May 28, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 249 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Cargo test   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Use of unstable library feature `unsigned_is_multiple_of` in libdatadog/libdd-profiling/src/internal/profile/interning_api/mod.rs:237

DataDog/apm-reliability/dd-trace-php | ZAI Shared Tests: [7.4]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error in libdatadog/libdd-trace-obfuscation/src/sql.rs:278: 'std::string::String::as_bytes' is not yet stable as a const fn. Add '#![feature(const_vec_string_slice)]' to crate attributes to enable.

DataDog/apm-reliability/dd-trace-php | ZAI Shared Tests: [8.0]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: `std::string::String::as_bytes` is not stable as a const fn in libdatadog/libdd-trace-obfuscation/src/sql.rs:278. Add `#![feature(const_vec_string_slice)]` to enable.

View all 249 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a4599e5 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 269af891ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libdatadog Outdated
@@ -1 +1 @@
Subproject commit cea1e44edddd9124f75d5095f31026904a1f58d8
Subproject commit 8ac735802ccd4eca304019be37960183a19bdaeb
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update Rust toolchains with this submodule bump

In environments that use this repo's pinned Rust 1.84.1 (Cargo.toml, profiling/rust-toolchain.toml, and the CI Dockerfiles), this new libdatadog SHA cannot be compiled because libdatadog at 8ac735802ccd4eca304019be37960183a19bdaeb declares workspace.package.rust-version = "1.87.0". Since profiling/Cargo.toml depends on libdatadog path crates, Cargo rejects the dependency before building; the toolchain/manifests/images need to be bumped alongside this gitlink, or the previous SHA kept.

Useful? React with 👍 / 👎.

@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 8ac73580 libdatadog update to f7d471dc May 28, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 269af89 to 578859b Compare May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot requested review from greghuels and leoromanovsky and removed request for a team May 28, 2026 16:34
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to f7d471dc libdatadog update to 2a659a6e May 29, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 578859b to f75861e Compare May 29, 2026 03:04
@dd-octo-sts dd-octo-sts Bot changed the title libdatadog update to 2a659a6e libdatadog update to 42d9ab04 May 30, 2026
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from f75861e to 405c9b4 Compare May 30, 2026 02:23
@dd-octo-sts dd-octo-sts Bot requested review from a team as code owners May 30, 2026 02:23
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 30, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-05-30 02:40:12

Comparing candidate commit 405c9b4 in PR branch bot/libdatadog-latest with baseline commit 095538e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 7 unstable metrics.

@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 405c9b4 to 2dc0884 Compare May 31, 2026 02:31
@dd-octo-sts dd-octo-sts Bot force-pushed the bot/libdatadog-latest branch from 2dc0884 to a4599e5 Compare June 1, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants