You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Title: Rename constant conflicting with built-in type: Hash
What does this PR do?
Renames Datadog::Tracing::Contrib::Utils::Quantization::Hash to Datadog::Tracing::Contrib::Utils::Quantization::HashFormatter.
Motivation: Datadog::Tracing::Contrib::Utils::Quantization::Hash collides with Ruby's standard Hash constant, when referenced through nested constant lookup.
This can cause you to reference Hash, normally wanting the std Hash class, but end up with Datadog::Tracing::Contrib::Utils::Quantization::Hash.
This PR introduces 1 untyped other declaration and 2 partially typed other declarations, and clears 1 untyped other declaration and 2 partially typed other declarations.
If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept on the line before the definition to remove it from the stats.
Comparing candidate commit 55eb893 in PR branch rename-quantization-hash-constant with baseline commit b1a5c02 in branch master.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 1 unstable metrics.
Explanation
This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:
🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline
We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.
If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.
Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.
More details about the CI and significant changes
You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.
CIs of the difference of means are often centered around 0%, because often changes are not that big:
---------------------------------(------|---^--------)-------------------------------->
-0.6% 0% 0.3% +1.2%
| | |
lower bound of the CI --' | |
sample mean (center of the CI) -------------' |
upper bound of the CI ----------------------'
As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).
For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:
----------------------------------------|---------|---(---------^---------)---------->
0% 1% 1.3% 2.2% 3.1%
| | | |
significant impact threshold --------------' | | |
lower bound of CI --------------' | |
sample mean (center of the CI) --------------------------' |
upper bound of CI ----------------------------------'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI GeneratedLargely based on code generated by an AI or LLM. This label is the same across all dd-trace-* reposintegrationsInvolves tracing integrationstracing
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Rename constant conflicting with built-in type: Hash
What does this PR do?
Renames
Datadog::Tracing::Contrib::Utils::Quantization::HashtoDatadog::Tracing::Contrib::Utils::Quantization::HashFormatter.Motivation:
Datadog::Tracing::Contrib::Utils::Quantization::Hashcollides with Ruby's standardHashconstant, when referenced through nested constant lookup.This can cause you to reference
Hash, normally wanting the stdHashclass, but end up withDatadog::Tracing::Contrib::Utils::Quantization::Hash.Change log entry
None. Internal.