Mark sender and timer threads as fork safe for Puma#315
Open
joshuay03 wants to merge 2 commits into
Open
Conversation
2371e4a to
c70dfad
Compare
nightpool
reviewed
Sep 23, 2025
c70dfad to
f672101
Compare
marcotc
approved these changes
Jan 6, 2026
a769866 to
e0846eb
Compare
Author
|
Bump 🙏🏽 |
Contributor
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0846eb6e0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
|
@joshuay03 Let me fix the CI so that we can run the tests for this PR. Sorry about that. |
43436b6 to
f9a43b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're in the process of enabling Puma's
preload_app!config at @buildkite. When auditing threads spawned during boot, Puma flagged this gem's sender thread as potentially notforksafe. However, based on the documentation for this gem and the implementation ofDatadog::Statsd::Sender#add, the sender thread appearsforksafe to me. The same reasoning applies to theStatsd Timerthread used whenbuffer_flush_intervalis configured, sinceSender#addalso restarts the flush timer after a fork.This PR adds a
:fork_safethread variable to both threads, which Puma uses to exclude them from its safety reporting, so that anyone else auditing their threads this way won't see false positives from this gem.Refs: