🐛 fix crash source_type mapping#127
Open
bcaudan wants to merge 1 commit into
Open
Conversation
- map minidump 'mac' → 'macos' (the processor returns 'mac', RUM expects 'macos') - explicitly map 'linux' and 'windows' (identity, but documented) - report a telemetry error for any unexpected OS value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
source_typefield on crash error events was incorrectly set on macOS. The WASM minidump processor (rust-minidump) returns"mac"for macOS, but the RUM schema expects"macos".The code was casting the raw OS string directly without any mapping, causing macOS crashes to be tagged with an invalid
source_type.Changes
OS_TO_SOURCE_TYPElookup table mapping minidump OS strings (mac,linux,windows) to the correct RUMsource_typevalues (macos,linux,windows)'mac'instead of'macos'), and add coverage forlinux,windows, and unknown OS valuesTest instructions
A crash on mac should be reported with
macossource typeChecklist