You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The QUEUE_ATTRIBUTES list in rabbitmq/datadog_checks/rabbitmq/const.py defines all queue-level metrics collected via the Management API. It includes ('message_bytes', 'message_bytes', float) but there is no entry for message_bytes_ram. The metadata.csv also does not contain a rabbitmq.queue.message_bytes_ram metric entry. To implement this FR, ('message_bytes_ram', 'message_bytes_ram', float) would need to be added to QUEUE_ATTRIBUTES in const.py and a corresponding row added to metadata.csv.
• Overall coverage for service rabbitmq: 68.24% (threshold: 75.00%)
⚠️ Warnings
🚦 11 Pipeline jobs failed
PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-mgmt), py3.13-3.11-mgmt) / RabbitMQ (py3.13-3.11-mgmt)-py3.13-3.11-mgmt
🔧 Fix in code (Fix with Cursor).
6 failed tests due to assertion errors: Some metrics are collected but not asserted, specifically 'rabbitmq.queue.message_bytes_ram' not being found amongst asserted metrics.
PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.7-mgmt), py3.13-3.7-mgmt) / RabbitMQ (py3.13-3.7-mgmt)-py3.13-3.7-mgmt
🔧 Fix in code (Fix with Cursor).
6 failed tests due to metrics not being asserted correctly including 'rabbitmq.queue.message_bytes_ram'.
PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-4.0-mgmt), py3.13-4.0-mgmt) / RabbitMQ (py3.13-4.0-mgmt)-py3.13-4.0-mgmt
🔧 Fix in code (Fix with Cursor).
6 failed tests. AssertionError: Some metrics are collected but not asserted: Found metrics that are not asserted: - rabbitmq.queue.message_bytes_ram. Check test_integration.py and test_unit.py for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by FBO — DRAFT for human review
Closes FRAGENT-1309
Reality-check reasoning
The
QUEUE_ATTRIBUTESlist inrabbitmq/datadog_checks/rabbitmq/const.pydefines all queue-level metrics collected via the Management API. It includes('message_bytes', 'message_bytes', float)but there is no entry formessage_bytes_ram. Themetadata.csvalso does not contain arabbitmq.queue.message_bytes_rammetric entry. To implement this FR,('message_bytes_ram', 'message_bytes_ram', float)would need to be added toQUEUE_ATTRIBUTESinconst.pyand a corresponding row added tometadata.csv.Learned from exemplar PRs: #20174, #19401, #19536, #20697, #23457
This PR was opened as a Draft. A human should review the diff,
re-run validators if needed, and mark Ready for Review.