Skip to content

[rabbitmq] [rabbitmq] Add message_bytes_ram metric collection#23873

Draft
mahipdeora25 wants to merge 1 commit into
masterfrom
fbo/c57000c7-rabbitmq-add-message-bytes-ram-metric-co
Draft

[rabbitmq] [rabbitmq] Add message_bytes_ram metric collection#23873
mahipdeora25 wants to merge 1 commit into
masterfrom
fbo/c57000c7-rabbitmq-add-message-bytes-ram-metric-co

Conversation

@mahipdeora25
Copy link
Copy Markdown
Contributor

Generated by FBO — DRAFT for human review

Closes FRAGENT-1309

Reality-check reasoning

The QUEUE_ATTRIBUTES list in rabbitmq/datadog_checks/rabbitmq/const.py defines all queue-level metrics collected via the Management API. It includes ('message_bytes', 'message_bytes', float) but there is no entry for message_bytes_ram. The metadata.csv also does not contain a rabbitmq.queue.message_bytes_ram metric entry. To implement this FR, ('message_bytes_ram', 'message_bytes_ram', float) would need to be added to QUEUE_ATTRIBUTES in const.py and a corresponding row added to metadata.csv.

Learned from exemplar PRs: #20174, #19401, #19536, #20697, #23457

This PR was opened as a Draft. A human should review the diff,
re-run validators if needed, and mark Ready for Review.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented May 28, 2026

Code Coverage  Pipelines  Tests

Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Total coverage percentage gate may be blocking this PR.

Overall coverage for service rabbitmq: 68.24% (threshold: 75.00%)

⚠️ Warnings

🚦 11 Pipeline jobs failed

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.11-mgmt), py3.13-3.11-mgmt) / RabbitMQ (py3.13-3.11-mgmt)-py3.13-3.11-mgmt   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). 6 failed tests due to assertion errors: Some metrics are collected but not asserted, specifically 'rabbitmq.queue.message_bytes_ram' not being found amongst asserted metrics.

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-3.7-mgmt), py3.13-3.7-mgmt) / RabbitMQ (py3.13-3.7-mgmt)-py3.13-3.7-mgmt   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). 6 failed tests due to metrics not being asserted correctly including 'rabbitmq.queue.message_bytes_ram'.

PR | test / test (linux, ubuntu-22.04, rabbitmq, RabbitMQ (py3.13-4.0-mgmt), py3.13-4.0-mgmt) / RabbitMQ (py3.13-4.0-mgmt)-py3.13-4.0-mgmt   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). 6 failed tests. AssertionError: Some metrics are collected but not asserted: Found metrics that are not asserted: - rabbitmq.queue.message_bytes_ram. Check test_integration.py and test_unit.py for more details.

View all 11 failed jobs.

🧪 6 Tests failed in 1 job

PR | run   GitHub Actions

test_family_tagging from test_integration.py   View in Datadog (Fix with Cursor)
Some metrics are collected but not asserted:
Asserted Metrics:
	- rabbitmq.connections
	- rabbitmq.exchange.messages.publish_in.count
	- rabbitmq.exchange.messages.publish_in.rate
	- rabbitmq.exchange.messages.publish_out.count
	- rabbitmq.exchange.messages.publish_out.rate
	- rabbitmq.node.disk_alarm
	- rabbitmq.node.disk_free
	- rabbitmq.node.fd_used
...
test_family_tagging_with_named_groups from test_integration.py   View in Datadog (Fix with Cursor)
Some metrics are collected but not asserted:
Asserted Metrics:
	- rabbitmq.connections
	- rabbitmq.exchange.messages.publish_in.count
	- rabbitmq.exchange.messages.publish_in.rate
	- rabbitmq.exchange.messages.publish_out.count
	- rabbitmq.exchange.messages.publish_out.rate
	- rabbitmq.node.disk_alarm
	- rabbitmq.node.disk_free
	- rabbitmq.node.fd_used
...

View all 6 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 58.89% (-28.49%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8baaf8f | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant