[rabbitmq] [rabbitmq] Add metric for unbalanced queue masters#23874
Draft
mahipdeora25 wants to merge 1 commit into
Draft
[rabbitmq] [rabbitmq] Add metric for unbalanced queue masters#23874mahipdeora25 wants to merge 1 commit into
mahipdeora25 wants to merge 1 commit into
Conversation
Contributor
Validation Report
Run Passed validations (20)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by FBO — DRAFT for human review
Closes FRAGENT-1039
Reality-check reasoning
There is no metric related to queue masters or unbalanced queue masters in the integration. The
QUEUE_ATTRIBUTESlist inconst.pydefines all queue metrics collected — it covers consumers, messages, memory, rates, etc., but contains nonode/mastertracking fields likesynchronised_slave_nodes,slave_nodes, or any "queue master" balance metric. Themetadata.csv(329 metrics) was scanned and shows nomasterorunbalancedmetric names. The FR asks for a new metric derived from RabbitMQ's HA/mirroring API (https://www.rabbitmq.com/ha.html) that would detect uneven distribution of queue masters across nodes — this logic does not exist anywhere in the current check code.Learned from exemplar PRs: #20174, #19401, #19536, #20697, #23457
This PR was opened as a Draft. A human should review the diff,
re-run validators if needed, and mark Ready for Review.