Skip to content

glusterfs: require trusted provider for gstatus_path#23881

Draft
NouemanKHAL wants to merge 3 commits into
masterfrom
noueman/glusterfs-gstatus-path-trusted-provider
Draft

glusterfs: require trusted provider for gstatus_path#23881
NouemanKHAL wants to merge 3 commits into
masterfrom
noueman/glusterfs-gstatus-path-trusted-provider

Conversation

@NouemanKHAL
Copy link
Copy Markdown
Member

What does this PR do?

Adds require_trusted_provider: true to the gstatus_path option in the GlusterFS integration spec, and regenerates the config models.

Motivation

gstatus_path is a filesystem path used to execute a binary. Restricting it to trusted providers prevents an untrusted config source from pointing it at an arbitrary executable.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@NouemanKHAL NouemanKHAL added the qa/skip-qa Automatically skip this PR for the next QA label May 29, 2026
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented May 29, 2026

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Check PR | run / Check PR changelog   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Package "glusterfs" has changes that require a changelog. Please run `ddev release changelog new` to add it.

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. License validation failed. Agent requirements file 'agent_requirements.in' is out of sync. Run 'ddev validate licenses --sync' to fix.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.00% (-11.42%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ef6499f | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 29, 2026

Validation Report

Validation Description Status
licenses Validate third-party license attribution list

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant