Skip to content

Import code from DataDog/libdatadog/ruby@19ae2be64#1

Merged
lloeki merged 21 commits into
mainfrom
lloeki/import-code
Mar 9, 2026
Merged

Import code from DataDog/libdatadog/ruby@19ae2be64#1
lloeki merged 21 commits into
mainfrom
lloeki/import-code

Conversation

@lloeki
Copy link
Copy Markdown
Member

@lloeki lloeki commented Mar 9, 2026

@lloeki lloeki changed the title Import code from DataDog/libdatadog/ruby@19ae2be64 Import code from DataDog/libdatadog/ruby@19ae2be64 Mar 9, 2026
@lloeki lloeki force-pushed the lloeki/import-code branch from 2272fe1 to 3157cd7 Compare March 9, 2026 08:58
@lloeki lloeki force-pushed the lloeki/import-code branch from 0dc9300 to 65c0994 Compare March 9, 2026 09:33
@lloeki lloeki requested review from TonyCTHsu, hoolioh and ivoanjo March 9, 2026 10:05
@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Mar 9, 2026

Before we move things here, can we give the same permissions, access-wise, to the repo as we have for dd-trace-rb and libdatadog? I'd like to keep the same environment of quick iteration and easy contribution as we've had so far in those

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Mar 9, 2026

Also, ideally since both dd-trace-rb and libdatadog are public, is there any reason not to make this one public as well?

@lloeki
Copy link
Copy Markdown
Member Author

lloeki commented Mar 9, 2026

can we give the same permissions, access-wise, to the repo as we have for dd-trace-rb and libdatadog?

I could swear I did so

EDIT: GH permissions were off for DataDog/ruby-guild, fixed; I punted on the shared components team ownership for now as it's a bit more unwieldy (lots of teams) but looking at the libdatadog CODEOWNERS set up it seems it's ruby-guild that's relevant so far.

@lloeki
Copy link
Copy Markdown
Member Author

lloeki commented Mar 9, 2026

Also, ideally since both dd-trace-rb and libdatadog are public, is there any reason not to make this one public as well?

Process 😭

(I asked on grounds that both were public but was denied and told to go through the whole vetting process)

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented Mar 9, 2026

It would suck to move from public to private just for that one reason. Can I maybe suggest keeping this inside libdatadog until we can make this repo public too?

Copy link
Copy Markdown
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me && @lloeki discussed over zoom that this is only the starting step for migrating away from having this on the libdatadog repo, and that the cut-off for moving things to this repo will only happen once we have everything set up, including marking the repo as public.

Comment thread .standard.yml
Comment thread libdatadog.gemspec Outdated
Comment thread LICENSE-3rdparty.yml
Comment thread NOTICE Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread README.md Outdated
@gh-worker-ownership-write-b05516 gh-worker-ownership-write-b05516 Bot removed the request for review from hoolioh March 9, 2026 11:02
Co-authored-by: Ivo Anjo <ivo@ivoanjo.me>
lloeki and others added 4 commits March 9, 2026 12:33
Co-authored-by: Ivo Anjo <ivo@ivoanjo.me>
These are provided by `libdatadog`'s tarball
Co-authored-by: Ivo Anjo <ivo@ivoanjo.me>
@lloeki lloeki requested a review from hoolioh March 9, 2026 13:23
@lloeki lloeki merged commit 6ee73b7 into main Mar 9, 2026
29 checks passed
@lloeki lloeki deleted the lloeki/import-code branch March 9, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants