Build in CI#34
Open
lloeki wants to merge 14 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbae8da144
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
These fail on aarch64-linux-musl
rustup is a no-go; from libdatadog itself:
Don't use rustup! For some reason it provides different native-static-libs
and this can cause problems for users.
Also, it doesn't understand x86_64-alpine-linux-musl like the OS's cargo.
Merged
Stop depending on Node 20
Strech
previously approved these changes
May 6, 2026
ivoanjo
requested changes
May 6, 2026
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
Some concerns -- see individual comments!
This comment has been minimized.
This comment has been minimized.
`setup-ruby` action uses whatever bundler is there, but some are old and broken. Pin them to most recent yet still compatible.
Needed for (a dependency of) `buidler` crate` which requires `edition2024` rust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
FUP to #33 (chained PR)
What does this PR do?
Use
builderto build in CIHow to test the change?
Watch CI; check those artifacts.
Additional Notes:
Had to split macos away because GitHub Actions doesn't support
container: {}orimage: nullor''or whatever.Next-in-chain PR: #37
JIRA: