refactor(span)!: use VecMap for meta, metrics and meta_struct for v04 spans#2043
Open
yannham wants to merge 9 commits into
Open
refactor(span)!: use VecMap for meta, metrics and meta_struct for v04 spans#2043yannham wants to merge 9 commits into
meta, metrics and meta_struct for v04 spans#2043yannham wants to merge 9 commits into
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: d3b289b | Docs | Datadog PR Page | Give us feedback! |
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
yannham
changed the title
meta, metrics and meta_struct
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## yannham/span-vec-fields #2043 +/- ##
===========================================================
- Coverage 72.92% 72.89% -0.04%
===========================================================
Files 460 460
Lines 76396 76471 +75
===========================================================
+ Hits 55711 55740 +29
- Misses 20685 20731 +46
🚀 New features to boost your workflow:
|
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
from
1c727ec to
a9e644d
Compare
yannham
commented
May 26, 2026
| size += k.as_ref().len() + v.as_ref().len(); | ||
| } | ||
| for k in self.metrics.keys() { | ||
| for (k, _) in &self.metrics { |
Contributor
Author
There was a problem hiding this comment.
TODO: this is wrong, because keys can be duplicated.
Solution 1: don't dedup. The size will be over-estimated.
Solution 2: deduplicate here. Costly (2 times with serialization).
Solution 3; deduplicate upfront (and eg keep a dirty flag in the vecmap to avoid double dedup).
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
2 times, most recently
from
681d36f to
95d3d03
Compare
yannham
changed the title
meta, metrics and meta_structmeta, metrics and meta_struct
yannham
changed the title
meta, metrics and meta_structmeta, metrics and meta_struct for v04 spans
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95d3d03685
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+59
to
+60
| let bytes_str_key = convert_char_slice_to_bytes_string(key); | ||
| map.insert(bytes_str_key, value); |
There was a problem hiding this comment.
When callers set the same meta/metric/meta_struct key more than once through the FFI, this now appends another entry instead of replacing the old one. The FFI getters hide this by returning the last value and key listing dedups, but the v04 serializer used by ddog_serialize_traces_to_bytes still writes span.meta.len() and iterates every entry in libdd-trace-utils/src/msgpack_encoder/v04/span.rs, so updates to an existing key are emitted as duplicate msgpack map keys and also inflate buffering size until flush. Please update existing entries here (or dedup before the manual encoders) to keep the previous HashMap semantics.
Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment.
Indeed, the msgpack encoding doesn't go through Serialize and needs to handle deduplication as well.
yannham
force-pushed
the
yannham/span-vec-fields
branch
from
74358f8 to
7e38b23
Compare
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
from
7c95b47 to
1336e90
Compare
The trace_buffer benchmark was still using HashMap for Span meta, metrics, and meta_struct fields after the VecMap migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The decoder functions were returning Vec<(K, V)> which callers immediately converted to VecMap via .into(). Return VecMap directly to avoid the unnecessary intermediate type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
from
1336e90 to
2d45a7f
Compare
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
from
2d45a7f to
8f43f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2022.
What does this PR do?
This PR continues the native span performance work required to land native spans in dd-trace-js. Follow-up of #2022. Actually use
VecMapin theSpandata structure.Motivation
Performance improvement following dd-trace-js native span experiments. See #2022.
How to test the change?
Run tests.