[SVLS-9015] Use consts and instance resolution logic from libdd-common#134
Draft
kathiehuang wants to merge 1 commit into
Draft
[SVLS-9015] Use consts and instance resolution logic from libdd-common#134kathiehuang wants to merge 1 commit into
kathiehuang wants to merge 1 commit into
Conversation
kathiehuang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With DataDog/libdatadog#2077 we moved the instance name resolution logic and any consts gathered from environment variabels to libdd-common. This PR updates the libdatadog rev and uses the libdd-common logic and public consts.
Motivation
https://datadoghq.atlassian.net/browse/SVLS-9015
Additional Notes
Describe how to test/QA your changes
Deployed an Azure Function and confirmed that the
instancetag in the instance enhanced metric is the same. See DataDog/libdatadog#2077 for testing theinstance_namespan attribute with screenshots.