Enable PHP FFE evaluation system tests#7003
Draft
leoromanovsky wants to merge 5 commits into
Draft
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 19b9c41 | Docs | Datadog PR Page | Give us feedback! |
4ca7546 to
984548d
Compare
984548d to
224c241
Compare
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DataDog/dd-trace-php#3906 adds the PHP runtime path for Feature Flags and Experimentation evaluation through live
FFE_FLAGSRemote Config and the nativelibdatadogevaluator. PHP should run the shared FFE evaluation system tests so that the runtime work has both end-to-end Remote Config coverage and canonical JSON fixture coverage before review and merge.Reference design doc: https://docs.google.com/document/d/1NvMfTpZWLBlFmEFNjdnlMyeVpy5l7KD8qujGFco6w2w/edit?tab=t.0
Changes
This PR enables the existing end-to-end
tests/ffe/test_dynamic_evaluation.pysuite for PHP starting atv1.20.0-devand adds the minimal PHP weblog/ffeendpoint needed by that shared suite. The endpoint calls theDDTrace\FeatureFlags\Clientdetails API exposed by the PHP runtime work, normalizes the request shape used by system-tests, and returns provider-not-ready defaults when the runtime is unavailable.This PR also enables the parametric canonical JSON fixture evaluation suite for PHP. The PHP parametric server now implements
/ffe/startand/ffe/evaluateusing the same Datadog client API.Decisions
The shared parametric test still requires the test-agent to observe an acknowledged
FFE_FLAGSRemote Config update. For PHP specifically, the test also passes the canonical UFC fixture into/ffe/start; the PHP parametric server is a single long-lived CLI request, so this seeds that process with the same fixture via the extension testing loader before the reallibdatadogevaluator is exercised. That keeps the parametric suite focused on evaluator correctness while the end-to-end suite validates live RC delivery into PHP request handling.The scope is deliberately evaluation-only. Exposure forwarding and
feature_flag.evaluationsmetrics remain disabled here so they can be enabled in separate stacked PRs after their runtime implementations are ready.Verification
Local validation was run against locally built dd-trace-php artifacts from DataDog/dd-trace-php#3906, not a released tracer.
Build inputs:
224c241208532a6b16b1ea907e4638516201a50d4cf261de35a6915711a7998d60f921bd8d14d502/Users/leo.romanovsky/go/src/github.com/DataDog/dd-trace-php-pr3906-reviewProof from local runs:
Supporting commands run locally:
DOCKER_CONFIG=/tmp/codex-docker-no-creds DOCKER_HOST=unix://$HOME/.colima/default/docker.sock ./format.sh: passed./tooling/bin/build-debug-artifact gnu-aarch64-8.2-nts /Users/leo.romanovsky/go/src/github.com/DataDog/system-tests-pr-g-php-ffe-scaffold/binariesfrom the PR 3906 checkout: passed./tooling/bin/build-debug-artifact gnu-aarch64-8.0-nts /Users/leo.romanovsky/go/src/github.com/DataDog/system-tests-pr-g-php-ffe-scaffold/binariesfrom the PR 3906 checkout: passedCI=true DOCKER_CONFIG=/tmp/codex-docker-no-creds DOCKER_HOST=unix://$HOME/.colima/default/docker.sock DOCKER_BUILDKIT=1 ./build.sh php -w apache-mod-8.0 -i weblog: passed