Skip to content

Tz reporter #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koconnor99-aq wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Tz reporter #640

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8ca258b
Adding timezone functionality to the reporter function
Mar 21, 2024
1b42b85
Removing unwanted files from a commit
Mar 21, 2024
8a7146c
changing startts endts to account for -localtime flag and nextperiod …
Apr 10, 2024
a459919
Removing unwanted /
Apr 10, 2024
cefee4c
adding considerations for non UK users who have localtime off
Apr 10, 2024
08563c3
cleaning up the conditional
Apr 10, 2024
4c33ccb
Update code/processes/reporter.q
koconnor99-aq Apr 10, 2024
b4d1e36
Update reporter.q
koconnor99-aq Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/processes/reporter.q
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ runreport:{[tab]
`..timerids upsert 1!select id,periodend:nextrun from .timer.timer where fp~/:funcparam;
:()];
/ - if timezone is specified convert the start and end timestamps to the time used by the system
startts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];gtime[startts]];startts];
endts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];gtime[endts]];endts];
startts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];?[`localtime in .proc.params;gtime[startts];startts]];startts];
endts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];?[`localtime in .proc.params;gtime[endts];endts]];endts];
Copy link
Copy Markdown
Member

@jonathonmcmurray jonathonmcmurray Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just check .proc.localtime here, and probably use $ instead of ?

Suggested change
startts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];?[`localtime in .proc.params;gtime[startts];startts]];startts];
endts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];?[`localtime in .proc.params;gtime[endts];endts]];endts];
startts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];$[.proc.localtime;gtime[startts];startts]];startts];
endts:?[not null tab[`timezone];.tz.ttz[`GMT;tab[`timezone];$[.proc.localtime;gtime[endts];endts]];endts];

/ - if the current time is within the start and end timestamps, use current time as start time, else use the startts
/ - work out the start time for the timer. For example a report could run every day from 10am to 6pm every 5 mins, if the reporter
/ - is started at 1:11pm, we need to know that the report should start 1:15pm and then run every 5 mins there after
Expand Down