Merge branch 'copy-fix' into 'enterprise'

QA fixes

See merge request dkinternal/testgen/dataops-testgen!314

Author: ci bot

testgen/commands/run_profiling_bridge.py

@@ -214,7 +214,7 @@ def run_profiling_in_background(table_group_id):
         empty_cache()
         background_thread = threading.Thread(
             target=run_profiling_queries,
-            args=(table_group_id, session.auth.user_display),
+            args=(table_group_id, session.auth.user_display if session.auth else None),
         )
         background_thread.start()
     else:

testgen/common/models/test_definition.py

@@ -2,7 +2,7 @@
 from dataclasses import dataclass
 from datetime import datetime
 from typing import Literal
-from uuid import UUID, uuid4
+from uuid import UUID
 
 import streamlit as st
 from sqlalchemy import (
@@ -147,7 +147,7 @@ class TestType(Entity):
 class TestDefinition(Entity):
     __tablename__ = "test_definitions"
 
-    id: UUID = Column(postgresql.UUID(as_uuid=True), default=uuid4)
+    id: UUID = Column(postgresql.UUID(as_uuid=True), server_default=text("gen_random_uuid()"))
     cat_test_id: int = Column(BigInteger, Identity(), primary_key=True)
     table_groups_id: UUID = Column(postgresql.UUID(as_uuid=True))
     profile_run_id: UUID = Column(postgresql.UUID(as_uuid=True))

testgen/ui/views/hygiene_issues.py

@@ -156,7 +156,7 @@ def render(
                 ("Likelihood", "likelihood_order"),
                 ("Action", "r.disposition"),
             )
-            default = [(sortable_columns[i][1], "ASC") for i in (0, 1)]
+            default = [(sortable_columns[i][1], "ASC") for i in (3, 0, 1)]
             sorting_columns = testgen.sorting_selector(sortable_columns, default)
 
         with actions_column:
@@ -434,10 +434,10 @@ def get_profiling_anomalies(
             THEN 'Potential PII: may require privacy policies, standards and procedures for access, storage and transmission.'
         END AS likelihood_explanation,
         CASE
-            WHEN t.issue_likelihood = 'Potential PII' THEN 1
-            WHEN t.issue_likelihood = 'Possible' THEN 2
-            WHEN t.issue_likelihood = 'Likely'   THEN 3
-            WHEN t.issue_likelihood = 'Definite'  THEN 4
+            WHEN t.issue_likelihood = 'Potential PII' THEN 4
+            WHEN t.issue_likelihood = 'Possible' THEN 3
+            WHEN t.issue_likelihood = 'Likely'   THEN 2
+            WHEN t.issue_likelihood = 'Definite'  THEN 1
         END AS likelihood_order,
         t.anomaly_description, r.detail, t.suggested_action,
         r.anomaly_id, r.table_groups_id::VARCHAR, r.id::VARCHAR, p.profiling_starttime, r.profile_run_id::VARCHAR,

testgen/ui/views/test_definitions.py

@@ -6,7 +6,7 @@
 
 import pandas as pd
 import streamlit as st
-from sqlalchemy import asc, func, tuple_
+from sqlalchemy import and_, asc, func, or_, tuple_
 from streamlit.delta_generator import DeltaGenerator
 from streamlit_extras.no_default_selectbox import selectbox
 
@@ -1184,13 +1184,16 @@ def get_test_definitions_collision(
     target_table_group_id: str,
     target_test_suite_id: str,
 ) -> pd.DataFrame:
+    table_tests = [(item["table_name"], item["test_type"]) for item in test_definitions if item["column_name"] is None]
+    column_tests = [(item["table_name"], item["column_name"], item["test_type"]) for item in test_definitions if item["column_name"] is not None]
     results = TestDefinition.select_minimal_where(
         TestDefinition.table_groups_id == target_table_group_id,
         TestDefinition.test_suite_id == target_test_suite_id,
         TestDefinition.last_auto_gen_date.isnot(None),
-        tuple_(TestDefinition.table_name, TestDefinition.column_name, TestDefinition.test_type).in_(
-            [(item["table_name"], item["column_name"], item["test_type"]) for item in test_definitions]
-        ),
+        or_(
+            tuple_(TestDefinition.table_name, TestDefinition.column_name, TestDefinition.test_type).in_(column_tests),
+            and_(tuple_(TestDefinition.table_name, TestDefinition.test_type).in_(table_tests), TestDefinition.column_name.is_(None)),
+        )
     )
     return to_dataframe(results, TestDefinitionMinimal.columns())
 

testgen/ui/views/test_results.py

@@ -805,7 +805,7 @@ def source_data_dialog(selected_row):
     st.caption(selected_row["test_description"])
 
     st.markdown("#### Test Parameters")
-    st.caption(selected_row["input_parameters"])
+    testgen.caption(selected_row["input_parameters"], styles="max-height: 100px; overflow: auto;")
 
     st.markdown("#### Result Detail")
     st.caption(selected_row["result_message"])