feat(schema): document [ALL] and [ADD] badges in schema legend (DRC-3466)#1434
Draft
danyelf wants to merge 3 commits into
Draft
feat(schema): document [ALL] and [ADD] badges in schema legend (DRC-3466)#1434danyelf wants to merge 3 commits into
danyelf wants to merge 3 commits into
Conversation
The schema-view legend listed only added / removed / changed, leaving the ALL (whole-model) and ADD (additive) badges from the lineage view and panel header undocumented. Add legend entries for both, reusing the existing treatment tokens so the chips match the in-product badges, gated on the same new_cll_experience flag that controls whether the badges render. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Danyel Fisher <danyel@gmail.com>
…the-whole-and-add-badges
…the-whole-and-add-badges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Extends the schema-view legend (top of the Columns tab) to document the two newer lineage markers that previously had no in-product reference:
[ALL]whole-model — every row in this model can be affected[ADD]additive — adds a column; existing rows unchangedBoth entries reuse the existing chip style and
wholeModelTreatmentTokensviapickTitleChip/pickGraphBadge+TreatmentChip— no new colors invented. The two new entries render only whennew_cll_experienceis enabled (the same flag that controls whether the badges render at all in the lineage graph / NodeView), so the legend never documents markers a user can't see. The existing+ added/- removed/~ changedentries are unchanged.Closes DRC-3466. Follow-up from DRC-3341.
Linked issues
How tested
SchemaLegendunit tests (8/8 pass): always-on added/removed/changed entries; whole-model + additive entries present with correct copy & aria-labels whennew_cll_experienceis on; both hidden when off.biome checkclean on changed files.tsc --noEmitexit 0.User-facing changes
The Columns-tab legend now explains the
[ALL]and[ADD]badges (when the new CLL experience is enabled). No behavior change to the badges themselves.Checklist