feat: custom ID resolvers#230
Open
UnbrandedTech wants to merge 8 commits into
Open
Conversation
Author
|
@DavidWells Do you have an opinion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to implement a @todo I saw in
@analytics/core:@TODO add custom value reolvers for userId and anonIdA small issue I encountered is that most public functions except the
analytics.user()function isasync. We can easily make the custom resolversasync(allowing network requests, etc.) but it would be a breaking change. I think this is a small enough addition that is very helpful in the short term, even without allowingasyncresolvers and the team/project can discuss changing the signature in a future major version.