Skip to content

Commit 3a0cb32

Browse files
kevinzwangbrettle
authored andcommitted
change to manipulator controls for manual climbing (#96)
* change to manipulator controls for climbing * im bad -kev
1 parent 34c28bf commit 3a0cb32

2 files changed

Lines changed: 12 additions & 18 deletions

File tree

Robot2019/src/main/java/frc/robot/OI.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public class OI {
8686
autoClimbBtn.toggleWhenPressed(new Climb(climber, dt, leftJoy));
8787

8888
manualClimbBtn = new JoystickButton(manipulator, Manip.LT_lTrigger);
89-
manualClimbBtn.toggleWhenPressed(new ManualClimb(climber, dt, leftJoy, rightJoy));
89+
manualClimbBtn.toggleWhenPressed(new ManualClimb(climber, manipulator));
9090

9191
toggleCameraBtn = new JoystickButton(leftJoy, 2);
9292
toggleCameraBtn.whenPressed(new ToggleCamera(driveCamera, hatchCamera, cameraServer));

Robot2019/src/main/java/frc/robot/commands/ManualClimb.java

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,26 +11,23 @@
1111
import edu.wpi.first.wpilibj.command.Command;
1212
import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard;
1313
import frc.robot.subsystems.Climber;
14-
import frc.robot.subsystems.Drivetrain;
1514

1615
public class ManualClimb extends Command {
1716
private Climber climber;
18-
private Drivetrain dt;
19-
private Joystick leftJoy, rightJoy;
17+
private Joystick manip;
2018

2119
final private double retractDist = 0;
2220
final private double climbDist = 24.46; // In inches
2321

24-
public ManualClimb(Climber climber, Drivetrain dt, Joystick leftJoy, Joystick rightJoy) {
22+
final private int climbJoyAxis = 1;
23+
24+
public ManualClimb(Climber climber, Joystick manip) {
2525
// Use requires() here to declare subsystem dependencies
2626
// eg. requires(chassis);
2727
requires(climber);
28-
requires(dt);
2928

3029
this.climber = climber;
31-
this.dt = dt;
32-
this.leftJoy = leftJoy;
33-
this.rightJoy = rightJoy;
30+
this.manip = manip;
3431
}
3532

3633
// Called just before this Command runs the first time
@@ -44,16 +41,14 @@ protected void initialize() {
4441
// Called repeatedly when this Command is scheduled to run
4542
@Override
4643
protected void execute() {
47-
double climbSpeed = -leftJoy.getY();
48-
double driveSpeed = -rightJoy.getY();
44+
double climbSpeed = manip.getRawAxis(climbJoyAxis);
4945

50-
if (climbSpeed > 0 && climber.getEncDistance() >= climbDist) {
51-
climbSpeed = 0;
52-
} else if (climbSpeed < 0 && climber.getEncDistance() <= retractDist) {
53-
climbSpeed = 0;
54-
}
46+
// if (climbSpeed > 0 && climber.getEncDistance() >= climbDist) {
47+
// climbSpeed = 0;
48+
// } else if (climbSpeed < 0 && climber.getEncDistance() <= retractDist) {
49+
// climbSpeed = 0;
50+
// }
5551
climber.runClimber(climbSpeed);
56-
dt.drive(driveSpeed, driveSpeed);
5752

5853
double angle = climber.getAngle();
5954
SmartDashboard.putNumber("Current Angle", angle);
@@ -75,7 +70,6 @@ protected boolean isFinished() {
7570
@Override
7671
protected void end() {
7772
climber.stopClimber();
78-
dt.stop();
7973
}
8074

8175
// Called when another command which requires one or more of the same

0 commit comments

Comments
 (0)