build(bundle): aggregate templates and colour emoji into graph-compose-bundle#305
Merged
Merged
Conversation
…e-bundle graph-compose-bundle is the batteries-included coordinate, but after the module split it only pulled the default PDF stack (the graph-compose wrapper = core + render-pdf) and the bundled fonts. Add the built-in templates (graph-compose-templates) and the colour-emoji set (graph-compose-emoji) so one dependency wires up everything a document commonly needs. The office backends (render-docx / render-pptx) stay opt-in and are not bundled. The emoji artifact carries its own version line, so pin it via a graphcompose.emoji.version property (mirroring the fonts pin) and guard the aggregator and bundle values against drift with bundledEmojiVersionAgreesAcrossModules. Refresh the bundle's Maven description, the README bundle and emoji notes, and the emoji release runbook to match the new contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
graph-compose-bundleis the batteries-included coordinate, but after the modulesplit it only pulled the default PDF stack (the
graph-composewrapper = core +render-pdf) and the bundled fonts. A consumer who wanted "everything wired up" still
had to add the templates and colour-emoji artifacts by hand.
What
bundle/pom.xmlnow aggregates the default PDF stack (via thegraph-composewrapper), the built-in templates (
graph-compose-templates), the bundled fonts,and the colour-emoji set (
graph-compose-emoji). The office backends(
graph-compose-render-docx/graph-compose-render-pptx) stay opt-in and are notbundled.
graphcompose.emoji.versionproperty (mirroring the fonts pin). A newbundledEmojiVersionAgreesAcrossModulesguard keeps the aggregator and bundlevalues from drifting.
release runbook are refreshed to match the new contents.
examplesandbenchmarksalready enumerate their dependencies explicitly and theaggregator module order is final, so no consumer changes were needed.
Tests
clean verify: BUILD SUCCESS;VersionConsistencyGuardTest9 tests(adds the emoji drift guard).
dependency:treeon the bundle resolvesgraph-compose→ core + render-pdf(+ PDFBox),
graph-compose-templates,graph-compose-fonts:1.0.0, andgraph-compose-emoji:1.0.0— and nothing else.