test: remove the legacy ECS test layer and its harness#316
Merged
Conversation
The Entity-Component-System render/layout pipeline is dead on the canonical path (DocumentSession -> LayoutCompiler -> LayoutGraph -> FixedLayoutBackend); it was exercised only by a test harness and the suites driving it. Remove the harness (EngineComposerHarness + the engine-assembly builders), the ecs render-pipeline tests, the qa integration suites and root ECS unit tests that depend on them, and the layout-snapshot resources they alone consumed. Every feature they touched is already covered by a canonical DocumentSession test. Two suites tested live code through the harness, so their coverage is preserved harness-free: barcode rendering gains a canonical BarcodeRenderTest, and the shared image source/metadata cache (ImageSourceCache, on the canonical image path) gains a harness-free ImageDataCacheTest next to the cache in core. render-pdf no longer publishes a tests-classifier jar (its only consumer was the harness); qa drops that dependency. The core tests-classifier jar stays -- a few render-pdf backend tests still use its shared visual-test helper.
DemchaAV
force-pushed
the
build/2.0-r3-delete-ecs-tests
branch
from
da41856 to
4d289fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Entity-Component-System render/layout pipeline is dead on the canonical path
(
DocumentSession → LayoutCompiler → LayoutGraph → FixedLayoutBackend). It was kept aliveonly by a test harness (
EngineComposerHarness+ the engine-assembly builder layer) and thesuites driving it — ~15k lines of test code exercising internals nothing ships through.
What
engine-assemblybuilders, theengine.render.pdf.ecsrendertests, the qa integration suites and root ECS unit tests that depend on them (68 test
files), plus 6
layout-snapshots/integration/**resources they alone consumed.harness-free:
BarcodeRenderTest(renders QR + CODE128 throughDocumentSession) andImageDataCacheTest(the sharedImageSourceCacheon the canonical image path — movednext to the cache in core, no harness). Every other deleted feature is already covered by a
canonical DocumentSession test (tables →
TableBuilderColSpanTest/TableSlicePaginationTest,images →
DocumentSessionImageTest, pagination →PaginationEdgeCaseTest, shapes →ShapeContainerBuilderTest, custom fonts →EngineeringResumeSmokeTest, links →AddLinkShortcutTest).render-pdfno longer publishes a tests-classifier jar (its only consumer was the harness);qadrops that dependency. The core tests-classifier jar stays — a few render-pdfbackend tests still use its shared
com.demcha.testing.VisualTestOutputshelper.The ECS main classes are removed in a follow-up; this PR is the test layer only.
Tests
clean verify: BUILD SUCCESS, all 14 modules, no test failures, no baselinedrift.
ImageDataCacheTestcovered alive cache (not dead ECS) — fixed by the harness-free replacement above.