refactor(templates): move built-in CV icon resources into the templates module#326
Merged
Merged
Conversation
…es module
The CV preset icon SVGs (mint-editorial, monogram-sidebar, sidebar-portrait and
timeline-minimal, plus the sidebar portrait and the mint expertise badge) shipped
in graph-compose-core, but they are loaded only by graph-compose-templates through
SvgGlyph.fromResource("/templates/cv/...") — the presets and the loader both live
in that module. Move the 29 files so the resources sit with the code that reads
them; the classpath path is unchanged, so there are no Java changes. Core now
carries no template assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The built-in CV preset icons shipped in graph-compose-core, but nothing in core reads them. They are loaded only by graph-compose-templates — the four presets and the
SvgGlyph.fromResource("/templates/cv/…")loader all live in that module.templates/pom.xmlalready states the split intent: "a lean core carries none of it." These 29 SVGs were the last template asset still sitting in core, so the claim wasn't fully true.What
git mvof 29 SVG files (recorded as 100%-similarity renames — history preserved):Covers all four CV presets (
mint-editorial,monogram-sidebar,sidebar-portrait,timeline-minimal), plus the sidebarportrait.svgand the mintexpertise-badge.svg. The classpath path stays/templates/cv/<preset>/icons/<name>.svg, so no Java changes — only which artifact carries the resources (core → templates). Core now carries no template assets; the templates module packages them via the defaultsrc/main/resourceslayout (no new<resources>stanza needed).Tests
core → render-* → templates → testing → qa): BUILD SUCCESS, 639 tests, 0 failures, 0 skipped.WidgetSmokeTest10/10 (the directSvgGlyph.fromResource("/templates/cv/mint-editorial/icons/phone.svg")call),MintEditorialSmokeTest9,MonogramSidebarSmokeTest4,SidebarPortraitSmokeTest3,TimelineMinimalSmokeTest3,CoverLetterV2SmokeTest15.graph-compose-bundlereaches them via its existing templates dependency; thegraph-composewrapper never carried template resources and is unchanged.