backend: use structured response modeling in public profile endpoint#69
Open
Harxhit wants to merge 1 commit into
Open
backend: use structured response modeling in public profile endpoint#69Harxhit wants to merge 1 commit into
Harxhit wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added dedicated TypeScript interfaces for all public profile and card responses in
apps/backend/src/routes/public.ts. This provides full compile-time type safety and encourages consistent API contracts across the public endpoints.Closes #21
Type of Change
What Changed
public.ts:PublicProfileLinkUsernamePublicProfileResponseCardPublicProfileResponseUsernameCardPublicProfileResponseGET /:username(public profile)GET /card/:cardId(direct shared card)GET /:username/card/:cardId(username + card view)No functional changes — only improved type safety and documentation.
Checklist
pnpm -r run lintpasses).pnpm -r run typecheck).pnpm -r run test).console.logor debug statements left in the code.