Skip to content

Grids: stabilize kbn focus tests #34407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anna-shakhova merged 1 commit into from
Jul 21, 2026
+14 −5
Merged

Grids: stabilize kbn focus tests #34407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...cafe-devextreme/tests/dataGrid/common/keyboardNavigation/keyboardNavigation.functional.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6781,7 +6781,7 @@ test('Focus should be set to the grid to allow keyboard navigation when the focu
});

[true, false].forEach((focusedRowEnabled) => {
test.meta({ unstable: focusedRowEnabled })(`Focus should return to the last active cell when re-entering the rowsview via kbn if focusedRowEnabled=${focusedRowEnabled} (T1308919)`, async (t) => {
test(`Focus should return to the last active cell when re-entering the rowsview via kbn if focusedRowEnabled=${focusedRowEnabled} (T1308919)`, async (t) => {
// arrange
const button = new Button('#otherContainer');
const dataGrid = new DataGrid('#container');
Expand All @@ -6795,7 +6795,11 @@ test('Focus should be set to the grid to allow keyboard navigation when the focu
// act
await t
.click(searchPanel.input)
.pressKey('tab tab tab tab tab');
.pressKey('tab')
.pressKey('tab')
.pressKey('tab')
.pressKey('tab')
.pressKey('tab');

// assert
await t.expect(secondIDCell.isFocused).ok();
Expand All @@ -6811,13 +6815,18 @@ test('Focus should be set to the grid to allow keyboard navigation when the focu
.notOk('focus should be on the search panel');

// act
await t.pressKey('tab tab tab');
await t
.pressKey('tab')
.pressKey('tab')
.pressKey('tab');

// assert
await t.expect(secondIDCell.isFocused).ok();

// act
await t.pressKey('tab tab');
await t
.pressKey('tab')
.pressKey('tab');

// assert
await t.expect(button.isFocused).ok();
Expand Down
2 changes: 1 addition & 1 deletion e2e/testcafe-devextreme/tests/dataGrid/common/selection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { testScreenshot } from '../../../helpers/themeUtils';
fixture.disablePageReloads`Selection`
.page(url(__dirname, '../../container.html'));

test.meta({ unstable: true })('selectAll state should be correct after unselect item if refresh(true) is called inside onSelectionChanged (T1048081)', async (t) => {
test('selectAll state should be correct after unselect item if refresh(true) is called inside onSelectionChanged (T1048081)', async (t) => {
const dataGrid = new DataGrid('#container');

const firstRowSelectionCheckBox = new CheckBox(dataGrid.getDataCell(0, 0).getEditor().element);
Expand Down
Loading