DropDownButton – FilterBuilder editor does not close after clicking outside it when it is rendered via dropDownContentTemplate (T1300811)#34409
Open
markallenramirez wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses T1300811 where a FilterBuilder value editor embedded inside a DropDownButton dropDownContentTemplate does not close when clicking outside the editor, by adding an end-to-end regression test and extending the FilterBuilder TestCafe model to access the value editor’s TextBox.
Changes:
- Added
Field.getTextBox()helper to the TestCafe FilterBuilder field model. - Added a new TestCafe E2E test covering editor closing behavior when FilterBuilder is rendered in DropDownButton
dropDownContentTemplate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/testcafe-models/filterBuilder/field.ts | Adds a TextBox accessor for FilterBuilder field value editing. |
| e2e/testcafe-devextreme/tests/common/filterBuilder/filterBuilderEditor.ts | Adds regression test for closing the embedded editor on outside click (T1300811). |
Comment on lines
+25
to
+26
|
|
||
| getTextBox(): TextBox { return new TextBox(`.${CLASS.textBox}`) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.