fix: don't abort clean install when Homebrew prerequisites are missing#567
Open
DevSecNinja with Copilot wants to merge 5 commits into
Open
fix: don't abort clean install when Homebrew prerequisites are missing#567DevSecNinja with Copilot wants to merge 5 commits into
DevSecNinja with Copilot wants to merge 5 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix clean WSL install failure
fix: don't abort clean install when Homebrew prerequisites are missing
Jul 10, 2026
DevSecNinja
marked this pull request as ready for review
July 10, 2026 13:05
Owner
|
@copilot can you fix the failing test? |
Contributor
Author
Fixed in 8582e50. The
Correction: the commit hash is |
auto-merge was automatically disabled
July 10, 2026 15:07
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a clean Linux system (e.g. a fresh WSL distro)
git/curlaren't present yet — they're installed later by the package-install script. The Homebrew setup script (run_once_before_05-install-homebrew.sh.tmpl) hard-failed withexit 1on the missing dependency, aborting the entirechezmoi apply:Since Homebrew is optional on Linux, a missing prerequisite should not tank the whole install.
Changes
apt-get/dnf install(Ubuntu/Debian and Fedora/RHEL/CentOS) when passwordless sudo is available, instead of only printing a hint.command -vafter the install attempt; if anything is still missing it logs which deps remain andexit 0, lettingchezmoi applycontinue (the package script installs git/curl shortly after).exit 1, since Homebrew is required there and git/curl ship with the system.test-chezmoi-scripts.batsasserting the Linux auto-install commands exist and the script no longer hard-fails on missing deps.Notes
apt-get/dnfcalls use|| trueintentionally (script runs underset -euo pipefail); the subsequentSTILL_MISSINGre-check is the source of truth for per-dependency outcome and logging.package-utils: Windows package IDs can match by package suffix) is present on the base branch and untouched here.