Follow-up: align v1.6 capset snapshots and clean up exec-encoding docs/comments#63
Follow-up: align v1.6 capset snapshots and clean up exec-encoding docs/comments#63Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/Devolutions/now-proto/sessions/b50b8124-c238-47eb-94d6-35622f46a2f1 Co-authored-by: vnikonov-devolutions <246051166+vnikonov-devolutions@users.noreply.github.com>
This is incorrect expected behavior. If both flags are specified, server should still inject command for unicode console, but client code should not assume the stream will contain. I actually like the original suggestion: |
Agent-Logs-Url: https://github.com/Devolutions/now-proto/sessions/b14b3d02-0117-4afd-8fbe-d2df8dd98c00 Co-authored-by: vnikonov-devolutions <246051166+vnikonov-devolutions@users.noreply.github.com>
Updated in commit 1edb76a. I changed the spec so combined RAW_ENCODING + UNICODE_CONSOLE now requires applying both behaviors (enable Unicode console startup and skip stdout/stderr transcoding), and clarified clients must treat returned bytes as raw output without assuming a specific encoding. |
This follow-up addresses post-review issues from the UTF-8 transcoding / Unicode console support work. It fixes failing .NET capset snapshot tests after the protocol default/version change and resolves documentation/comment formatting gaps flagged in review.
.NET tests: update capset wire snapshots for protocol v1.6
NowProtoVersion.Current = 1.6.Spec: clarify combined RAW + UNICODE behavior
NOW_EXEC_FLAG_PS_RAW_ENCODING.Rust docs: fix malformed doc comment rendering
\nsequence and corrected indentation inNowExecCapsetFlags::UNICODE_CONSOLEdocs so rustdoc renders correctly.C# formatting: remove accidental blank lines
NowProtoVersion.csnearCurrent.