[Unit Tests] Filter system, Loadout active abilities, and shared test stubs coverage

[DiamondDagger590]

Summary

• Filter system tests (0% → covered): Added comprehensive tests for all 10 filter classes — ActiveAbilityFilter, PassiveAbilityFilter, UnlockableAbilityFilter, InnateAbilityFilter, AbilityUpgradeFilter, AbilityKeyComboActivatableFilter, AbilityKeyUnlockedFilter, AbilityKeyInLoadoutFilter, McRPGChainPlayerContextFilter, and SkillHolderDataPresentFilter
• Loadout active abilities tests: Added tests for Loadout.getOrderedActiveAbilities() and Loadout.swapActivePositions() covering combo ability ordering, passive interspersion, same-slot no-op, out-of-range slots, zero slots, negative index edge case, and empty loadout
• Shared test stubs fixture: Extracted StubAbilityBase, StubActiveUnlockableAbility, StubPassiveUnlockableAbility, StubInnateAbility, and StubComboActivatableAbility into src/testFixtures/java/us/eunoians/mcrpg/ability/stub/ to eliminate duplication across test files

Classes covered (previously at 0% or no tests)

Class	Tests added
ActiveAbilityFilter	3
PassiveAbilityFilter	2
UnlockableAbilityFilter	2
InnateAbilityFilter	4
AbilityUpgradeFilter	5
AbilityKeyComboActivatableFilter	3
AbilityKeyUnlockedFilter	3
AbilityKeyInLoadoutFilter	3
McRPGChainPlayerContextFilter	3
SkillHolderDataPresentFilter	2
Loadout (active abilities)	10

Total: 40+ new test cases across 5 test files and 5 shared fixture classes

Test plan

• All 2333+ tests pass via ./gradlew verifiedShadowJar
• No regressions in existing test classes
• Shared stubs compile from testFixtures and are accessible in test source set
• Persona testing audit run against changes

https://claude.ai/code/session_013xEDA3KdWh2GVKGbM6XA59

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

@DiamondDagger590, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 188a6589-e0c4-45dd-b617-5036c54a99c3

📥 Commits

Reviewing files that changed from the base of the PR and between 9b47c9a and 14e69be.

📒 Files selected for processing (10)

• src/test/java/us/eunoians/mcrpg/loadout/LoadoutActiveAbilitiesTest.java
• src/test/java/us/eunoians/mcrpg/util/filter/ability/AbilityFilterTest.java
• src/test/java/us/eunoians/mcrpg/util/filter/core/McRPGChainPlayerContextFilterTest.java
• src/test/java/us/eunoians/mcrpg/util/filter/key/AbilityKeyFilterTest.java
• src/test/java/us/eunoians/mcrpg/util/filter/skill/SkillHolderDataPresentFilterTest.java
• src/testFixtures/java/us/eunoians/mcrpg/ability/stub/StubAbilityBase.java
• src/testFixtures/java/us/eunoians/mcrpg/ability/stub/StubActiveUnlockableAbility.java
• src/testFixtures/java/us/eunoians/mcrpg/ability/stub/StubComboActivatableAbility.java
• src/testFixtures/java/us/eunoians/mcrpg/ability/stub/StubInnateAbility.java
• src/testFixtures/java/us/eunoians/mcrpg/ability/stub/StubPassiveUnlockableAbility.java

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/brave-goldberg-jOCI1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}