[Unit Tests] LocaleSettingChain, BleedManager, and McRPGDisplayDecimalFormatter coverage#240
[Unit Tests] LocaleSettingChain, BleedManager, and McRPGDisplayDecimalFormatter coverage#240DiamondDagger590 wants to merge 2 commits into
Conversation
…DecimalFormatter - LocaleSettingChain (0% → 100%): 14 tests covering chain building, node lookup, circular navigation, alphabetical ordering, blank locale filtering, and unknown locale fallback - BleedManager (0% → 100%): 28 tests covering state queries (isEntityBleeding, isEntityBleedImmune, canEntityStartBleeding), state mutations (stop, end immunity), startBleeding guards, immunity expiration via scheduler, and full lifecycle integration - McRPGDisplayDecimalFormatter (35% → 100%): 12 new tests covering McRPGPlayer overloads with locale chain resolution, Audience overloads for loaded/unloaded players and non-Player audiences, and all no-manager-throws paths for every overload variant https://claude.ai/code/session_013g1ovt1fojJgK2y5hJxzGM
|
Warning Review limit reached
More reviews will be available in 50 minutes and 18 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Addresses testing audit finding: the holder-tracking path was only tested with a null holder. Adds a test with a real AbilityHolder instance to verify the non-null path. https://claude.ai/code/session_013g1ovt1fojJgK2y5hJxzGM
Summary
Classes covered
LocaleSettingChainBleedManagerMcRPGDisplayDecimalFormatterTotal: 54 new test cases across 3 test files
Test plan
./gradlew verifiedShadowJarhttps://claude.ai/code/session_013g1ovt1fojJgK2y5hJxzGM
Generated by Claude Code