[Unit Tests] ComboManager processInput/resetState, QuestBoard, and ExperienceDisplaySetting advanced coverage

[DiamondDagger590]

Summary

• ComboManagerProcessInputTest: Full coverage of processInput() — RIGHT starts combo, LEFT when empty is no-op, non-allowed items skip processing, empty hand (AIR) is always allowed, unregistered player is a no-op. Pattern completions (RRR→SLOT_1, RRL→SLOT_2, RLR→SLOT_3) with event slot index verification via registered listener. Dead-end sequences (RLL) reset state. resetState(UUID) and resetState(McRPGPlayer) clear sequence and timeout. Timeout scheduling, refresh on each input, and expiration behavior tested via MockBukkit scheduler.
• QuestBoardTest: Config-backed getters (maxAcceptedQuests, minimumTotalOfferings, maxScopedQuestsPerEntity), daily/weekly rotation set/get/replace/null-clear, rotation independence, reloadable content set size (3), immutability, and config reload propagation. Pure Mockito test — no MockBukkit dependency.
• ExperienceDisplaySettingAdvancedTest: getExperienceDisplay() factory returns correct subclass (BossBar/ActionBar) with matching setting enum. onSettingChange() rebuilds display when one exists, does not create when none exists. sendExperienceUpdate() short-circuits when config display is disabled.

Coverage impact

Class	Before	After
ComboManager	~39%	~99%
QuestBoard	0%	~100%
ExperienceDisplaySetting	~42%	~73%

Test plan

• All 3 new test classes pass independently
• Full test suite passes (2337+ tests, zero failures)
• Testing audit persona findings addressed (fixed timestamps, added event slot verification, added null rotation tests, added unregistered player edge case, fixed inline FQN import)

https://claude.ai/code/session_01UMjC2xGVHJjKNxWkRFisnL

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

@DiamondDagger590, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 25 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: db07d87a-3b55-4ed0-8592-8d6c5844dbe8

📥 Commits

Reviewing files that changed from the base of the PR and between 9b47c9a and ee36b0e.

📒 Files selected for processing (3)

• src/test/java/us/eunoians/mcrpg/ability/combo/ComboManagerProcessInputTest.java
• src/test/java/us/eunoians/mcrpg/quest/board/QuestBoardTest.java
• src/test/java/us/eunoians/mcrpg/setting/impl/ExperienceDisplaySettingAdvancedTest.java

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/brave-goldberg-kxzaco

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}