Skip to content

[Unit Tests] BoardOffering templates, LoadoutResolution, loadout exceptions, quest definition coverage#255

Open
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/brave-goldberg-84uwy4
Open

[Unit Tests] BoardOffering templates, LoadoutResolution, loadout exceptions, quest definition coverage#255
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/brave-goldberg-84uwy4

Conversation

@DiamondDagger590

Copy link
Copy Markdown
Owner

Summary\n\nAdds 5 new test classes covering previously untested code paths (all were at 0% coverage):\n\n- BoardOfferingTemplateTest — Template-specific constructors, isTemplateGenerated(), getTemplateKey(), getGeneratedDefinition(), database reconstruction with template metadata, and template offering state transitions (accept, expire, complete, abandon)\n- LoadoutResolutionTest — Sealed interface LoadoutResolution with all three record variants (Found, Ambiguous, NotFound): wrapping, equals/hashCode, type discrimination\n- LoadoutExceptionTestLoadoutMaxSizeExceededException, SelectedLoadoutAboveMaxException, SkillHolderMissingSkillException: both constructor variants, getter preservation, RuntimeException inheritance\n- QuestObjectiveDefinitionExpressionTest — Expression-based constructor validation (blank/empty), resolveRequiredProgress with tier variables, zero/negative resolution guards, static constructor validation, reward distribution Optional behavior, description route, rewards immutability\n- QuestDefinitionRewardDistributionTestQuestPhaseDefinition and QuestStageDefinition reward distribution Optional behavior, stage ordering preservation, QuestRepeatMode enum (parameterized), PhaseCompletionMode enum\n\n## Test plan\n\n- [x] All 5 new test files pass individually\n- [x] Full test suite passes (./gradlew verifiedShadowJar — BUILD SUCCESSFUL)\n- [x] Testing audit persona (persona-testing.mdc) checklist applied — one finding fixed (converted QuestRepeatMode round-trip loop to @ParameterizedTest/@EnumSource)\n- [x] No overlap with existing open test PRs (#238#254)\n\n🤖 Generated with Claude Code\n\nhttps://claude.ai/code/session_01HL54NfYMKTAsxFS2ndVUim


Generated by Claude Code

…t exceptions, quest definitions

Cover previously untested code paths:
- BoardOffering template constructors, template metadata, template state transitions
- LoadoutResolution sealed interface (Found, Ambiguous, NotFound records)
- LoadoutMaxSizeExceededException, SelectedLoadoutAboveMaxException, SkillHolderMissingSkillException
- QuestObjectiveDefinition expression-based constructor and resolveRequiredProgress
- QuestPhaseDefinition/QuestStageDefinition reward distribution and ordering
- QuestRepeatMode and PhaseCompletionMode enum coverage

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HL54NfYMKTAsxFS2ndVUim
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DiamondDagger590, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 53 minutes and 3 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: feac856c-c93e-4e34-80b4-eb2111377211

📥 Commits

Reviewing files that changed from the base of the PR and between 9b47c9a and 0939920.

📒 Files selected for processing (5)
  • src/test/java/us/eunoians/mcrpg/exception/LoadoutExceptionTest.java
  • src/test/java/us/eunoians/mcrpg/loadout/LoadoutResolutionTest.java
  • src/test/java/us/eunoians/mcrpg/quest/board/BoardOfferingTemplateTest.java
  • src/test/java/us/eunoians/mcrpg/quest/definition/QuestDefinitionRewardDistributionTest.java
  • src/test/java/us/eunoians/mcrpg/quest/definition/QuestObjectiveDefinitionExpressionTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/brave-goldberg-84uwy4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants