[Unit Tests] OreScannerBlockType, DistanceTraveled, EnchantItem, SmeltItem objective type coverage#256
Open
DiamondDagger590 wants to merge 1 commit into
Open
[Unit Tests] OreScannerBlockType, DistanceTraveled, EnchantItem, SmeltItem objective type coverage#256DiamondDagger590 wants to merge 1 commit into
DiamondDagger590 wants to merge 1 commit into
Conversation
…tItem objective type coverage Add new OreScannerBlockType test (14 tests) covering accessors, set immutability, isBlockScannable, and record equality. Rewrite 3 quest objective type tests from ~4 tests each to comprehensive suites: DistanceTraveledObjectiveType (~20 tests including all 6 TravelMode detections), EnchantItemObjectiveType (~15 tests including dual item+enchantment filtering), SmeltItemObjectiveType (~14 tests including material filter parsing and multi-item extraction). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SdDAAR4T8BADeC1gdjJ8Jv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OreScannerBlockTypeTest— 14 tests covering record accessors, set immutability,isBlockScannablematching, and record equality/hashCode. Pure JUnit (no McRPGBaseTest needed).DistanceTraveledObjectiveTypeTest— expanded from 4 to ~20 tests. Now coversparseConfigwith empty/single/multiple/case-insensitive modes,processProgressedge cases, and all 6TravelModedetections (FOOT, HORSE, BOAT, MINECART, ELYTRA, PIG) including priority rules.EnchantItemObjectiveTypeTest— expanded from 4 to ~15 tests. Now covers dual item+enchantment filtering,parseConfigwith no keys/items only/enchantments only, andprocessProgresswith all filter combinations.SmeltItemObjectiveTypeTest— expanded from 4 to ~14 tests. Now covers material filter parsing, invalid material handling, empty filter lists, multi-item extraction, and multi-material filter matching.Coverage impact
OreScannerBlockTypeDistanceTraveledObjectiveTypeEnchantItemObjectiveTypeSmeltItemObjectiveTypeTest plan
./gradlew verifiedShadowJarpasses (clean → test → build)action_outcome_whenConditionnaming with@DisplayName@Nestedgrouping by logical section (Identity, CanProcess, ParseConfig, ProcessProgress, etc.)review-testing) applied — no concerns found🤖 Generated with Claude Code
https://claude.ai/code/session_01SdDAAR4T8BADeC1gdjJ8Jv
Generated by Claude Code