Skip to content

[Unit Tests] BlockPlace, ConsumeItem, FishCatch, HarvestCrop objective type coverage#258

Open
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/brave-goldberg-eu8w2s
Open

[Unit Tests] BlockPlace, ConsumeItem, FishCatch, HarvestCrop objective type coverage#258
DiamondDagger590 wants to merge 1 commit into
recodefrom
claude/brave-goldberg-eu8w2s

Conversation

@DiamondDagger590

Copy link
Copy Markdown
Owner

Summary

  • Expanded test coverage for BlockPlaceObjectiveType, ConsumeItemObjectiveType, FishCatchObjectiveType, and HarvestCropObjectiveType from ~4 tests each to 11 tests each
  • Tests organized into @Nested groups: Identity, CanProcess, ProcessProgress, ParseConfig
  • Coverage improved from ~17-18% to 56.4% for all 4 classes
  • Remaining uncovered lines are describeObjective() methods which require localization manager mocking (known gap, consistent with other test PRs)

Test plan

  • All 44 new tests pass (./gradlew verifiedShadowJar)
  • Full test suite passes with zero failures
  • Testing audit persona reviewed — no concerns found
  • Tests follow action_outcome_whenCondition naming and short @DisplayName labels
  • All tests extend McRPGBaseTest
  • No direct MockBukkit.mock()/unmock() calls

🤖 Generated with Claude Code

https://claude.ai/code/session_01JAX6Xj3jQFRoRvRPmRCW6h


Generated by Claude Code

…atchObjectiveType, HarvestCropObjectiveType coverage

Expand test coverage for 4 quest objective types from ~4 tests each
to 11 tests each. Tests cover identity (getKey, getExpansionKey),
canProcess (correct and incorrect context types), processProgress
(wrong context, empty filter, matching filter, non-matching filter,
multi-item filter), and parseConfig (no config key, with config key).

Coverage improved from ~17-18% to 56.4% for all 4 classes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JAX6Xj3jQFRoRvRPmRCW6h
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DiamondDagger590, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 19 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f1bbbe68-03f4-4f87-b6da-bd294cc1c61a

📥 Commits

Reviewing files that changed from the base of the PR and between 9b47c9a and a5f57c2.

📒 Files selected for processing (4)
  • src/test/java/us/eunoians/mcrpg/quest/objective/type/builtin/BlockPlaceObjectiveTypeTest.java
  • src/test/java/us/eunoians/mcrpg/quest/objective/type/builtin/ConsumeItemObjectiveTypeTest.java
  • src/test/java/us/eunoians/mcrpg/quest/objective/type/builtin/FishCatchObjectiveTypeTest.java
  • src/test/java/us/eunoians/mcrpg/quest/objective/type/builtin/HarvestCropObjectiveTypeTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/brave-goldberg-eu8w2s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants