Skip to content

Fix i04 bugs#1713

Merged
jacob720 merged 5 commits into
mainfrom
1704_i04_fixes
May 14, 2026
Merged

Fix i04 bugs#1713
jacob720 merged 5 commits into
mainfrom
1704_i04_fixes

Conversation

@jacob720
Copy link
Copy Markdown
Contributor

Fixes #1704
Fixes XRC and beam centring bugs found in testing.

Link to dodal PR (if required): #XXX
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@jacob720 jacob720 requested a review from a team as a code owner April 28, 2026 17:11
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
Approved

@jacob720 jacob720 enabled auto-merge (squash) May 14, 2026 09:43
@jacob720 jacob720 added the i04 Changes relating to I04 label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.89%. Comparing base (67e1969) to head (64e356e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1713   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files         159      159           
  Lines        8679     8679           
=======================================
  Hits         8062     8062           
  Misses        617      617           
Components Coverage Δ
i24 SSX 77.15% <ø> (ø)
hyperion 98.73% <ø> (ø)
other 98.18% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 merged commit 1a51791 into main May 14, 2026
15 checks passed
@jacob720 jacob720 deleted the 1704_i04_fixes branch May 14, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i04 Changes relating to I04

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I04 issues 22/04/26

2 participants