simplify hyperion restart#1744
Open
rtuck99 wants to merge 8 commits into
Open
Conversation
Widen scope to find processes regardless of parent directory name
Fix vanilla UDC not always stopped
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 156 156
Lines 8563 8563
=======================================
Hits 7953 7953
Misses 610 610
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
hyperion_restart()for blueapi #1737Also requires
Link to dodal PR (if required): #N/A
As used from GDA,
hyperion_restart()should always kill all hyperion processes, however separate launching of supervisor and blueapi is retained for use direct from the command line viarun_hyperion.sh.Blueapi is now started in a separate process group to avoid being sent the SIGINT by
gda_launcherwhich was terminating the process on GDA server shutdown.Checks for reviewer