Skip to content

Fix system test breakage due to merge conflicts#1751

Merged
rtuck99 merged 1 commit into
mainfrom
fix_system_tests_errata
May 18, 2026
Merged

Fix system test breakage due to merge conflicts#1751
rtuck99 merged 1 commit into
mainfrom
fix_system_tests_errata

Conversation

@rtuck99
Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 commented May 18, 2026

Fixes system tests which would have been fixed by #1686 except that a couple of changes got lost while resolving merge conflicts.

Link to dodal PR (if required): #N/A
(remember to update pyproject.toml with the dodal commit tag if you need it for tests to pass!)

Instructions to reviewer on how to test:

  1. System tests pass
    https://gitlab.diamond.ac.uk/MX-GDA/hyperion-system-testing/-/pipelines/133573/test_report

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.01%. Comparing base (f3ddc4a) to head (c3e8979).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         164      164           
  Lines        8907     8907           
=======================================
  Hits         8285     8285           
  Misses        622      622           
Components Coverage Δ
i24 SSX 77.15% <ø> (ø)
hyperion 98.73% <ø> (ø)
other 98.16% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99 rtuck99 added the dev experience Changes relating to developer experience label May 18, 2026
@rtuck99 rtuck99 marked this pull request as ready for review May 18, 2026 12:37
@rtuck99 rtuck99 requested a review from a team as a code owner May 18, 2026 12:37
@rtuck99 rtuck99 merged commit 4d1ef1e into main May 18, 2026
28 of 29 checks passed
@rtuck99 rtuck99 deleted the fix_system_tests_errata branch May 18, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev experience Changes relating to developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants