feat: support @ mentions in chat message reply#451
Open
mvanhorn wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dws chat message replynow accepts--at-open-dingtalk-ids <csv>and--at-all, forwardingatOpenDingTalkIds/isAtAllto the upstreamsend_personal_messagetool. The reply content goes through the samemarshalMessageContentpath aschat message send, so<@...>placeholders reach DingTalk clients unescaped. Flag help, both skill reference docs, and CHANGELOG.md document that--textmust contain matching<@openDingTalkId>/<@all>placeholders.This closes the gap in #359: an agent that polls
chat message list-mentionsand replies in-thread had no way to notify the original sender, even though the upstream tool schema already supports these fields (confirmed in #310). The implementation follows the landing plan PeterGuy326 laid out in the issue thread: pure CLI passthrough mirroring the send command's flag names andsplitCSVStringshandling, with no changes to the bot/webhook send paths.Verification
make buildmake lintmake testmake policy./scripts/policy/check-generated-drift.sh./scripts/policy/check-command-surface.sh --strict(command surface changed: two new reply flags)Notes
Table-driven tests cover ids-only, at-all, no-flags (params identical to current behavior), and whitespace-only ids. On
make test, the cli, contract, and mock_mcp suites pass; the integration/extensions, integration/recovery, and scripts suites fail identically on a clean upstream/main checkout in this environment, so those failures are pre-existing and unrelated to this change. No risks beyond the new optional flags; behavior without them is unchanged.Fixes #359