fix(manganis): preserve original image bytes when no transform requested#5677
Closed
Functionhx wants to merge 1 commit into
Closed
fix(manganis): preserve original image bytes when no transform requested#5677Functionhx wants to merge 1 commit into
Functionhx wants to merge 1 commit into
Conversation
…nsform
asset!("x.png") with no options resolves to ImageAssetOptions::default()
(format: Unknown, size: Automatic). In process_image that fell through to
image.save(), decoding and re-encoding the PNG with the image crate's default
encoder — which can significantly inflate an already-optimized image (#5642,
e.g. 193K -> 976K).
Add an early guard: when no output format and no manual size are requested,
copy the source bytes verbatim (still hashed by filename) instead of decoding
and re-encoding. Explicit .with_format()/.with_size() paths are unchanged.
Adds a regression test asserting default-options output is byte-identical to a
Best-compressed source PNG carrying a tEXt chunk (which a re-encode would drop).
WaterWhisperer
left a comment
WaterWhisperer
left a comment
There was a problem hiding this comment.
This PR contains the exact same commit as #5675 (e2239b8), which was opened earlier by @singhlovepreet9 . Why was the same commit submitted again from a different account?
There was a problem hiding this comment.
Oh, this looks exactly the same as #5675
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5642.
asset!() re-encodes PNG through the image crate, inflating file size (193K→976K). Default-option images are decoded and re-compressed instead of copied verbatim.
Added early return in process_image() — fs::copy byte-for-byte when no format conversion or resize is requested. Explicit transforms still go through full decode→resize→encode pipeline.
3 observations from isolation review (non-blocking):