added analytic empty-state#393
Conversation
|
@Jumongweb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Analytics now lazy-loads jsPDF on main, which conflicts with this PR's top-level import approach. please rebase onto current main (keeping the lazy import) and re-push, then i'll land it. https://discord.gg/xvNAvMJf |
|
this one collides hard with analytics + create vault work that already landed on main — your version rewrites the same pdf export and create-vault flow rather than adding to them, so it won't merge cleanly. could you rebase on latest main and rework on top of the current implementations? happy to take another look after. shout in https://discord.gg/xvNAvMJf if you want to talk it through. |
5568647 to
09e99ff
Compare
|
Rebased onto latest main, kept the lazy jsPDF import, and reworked the create-vault changes on top of current main. The branch is pushed and the PR is updated. |
|
nice, the empty-state placeholder reads much cleaner than bare axes. merged |
Summary
This PR hardens wallet balance handling, improves Create Vault form accessibility, respects reduced-motion in notifications, and adds empty states for Analytics periods with no chart data.
What changed
0.00fallback for accounts without the Circle USDC trustline.aria-invalid="true"and reference their inline errors througharia-describedby.usePrefersReducedMotionhook and use it to suppress NotificationIcon dropdown motion when reduced motion is preferred.No data for this periodplaceholder instead of empty charts.Testing
Notes
Closes
Closes #344
Closes #348
Closes #349
Closes #298