Skip to content

added analytic empty-state#393

Merged
1nonlypiece merged 1 commit into
Disciplr-Org:mainfrom
Jumongweb:security-a11y-wallet-createvault-notifications
Jun 28, 2026
Merged

added analytic empty-state#393
1nonlypiece merged 1 commit into
Disciplr-Org:mainfrom
Jumongweb:security-a11y-wallet-createvault-notifications

Conversation

@Jumongweb

Copy link
Copy Markdown
Contributor

Summary

This PR hardens wallet balance handling, improves Create Vault form accessibility, respects reduced-motion in notifications, and adds empty states for Analytics periods with no chart data.

What changed

  • Validate Horizon USDC balance strings before returning them to wallet UI state.
  • Preserve the existing 0.00 fallback for accounts without the Circle USDC trustline.
  • Add coverage for malformed Horizon balance payloads.
  • Ensure CreateVault invalid fields expose aria-invalid="true" and reference their inline errors through aria-describedby.
  • Add an error summary and focus the first invalid field on failed form submission.
  • Extract a shared usePrefersReducedMotion hook and use it to suppress NotificationIcon dropdown motion when reduced motion is preferred.
  • Detect empty Analytics period series and render a shared No data for this period placeholder instead of empty charts.
  • Document the wallet-balance, field accessibility, and analytics empty-state guarantees in the design-system docs.

Testing

  • Targeted tests passed for:
    • Horizon balance validation
    • CreateVault accessibility wiring and focus management
    • Reduced-motion hook and NotificationIcon behavior
    • Analytics empty-state rendering and period switching

Notes

  • The full repo test suite still has unrelated pre-existing failures outside this PR’s scope.

Closes

Closes #344
Closes #348
Closes #349
Closes #298

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@Jumongweb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@1nonlypiece

Copy link
Copy Markdown
Contributor

Analytics now lazy-loads jsPDF on main, which conflicts with this PR's top-level import approach. please rebase onto current main (keeping the lazy import) and re-push, then i'll land it. https://discord.gg/xvNAvMJf

@1nonlypiece

Copy link
Copy Markdown
Contributor

this one collides hard with analytics + create vault work that already landed on main — your version rewrites the same pdf export and create-vault flow rather than adding to them, so it won't merge cleanly. could you rebase on latest main and rework on top of the current implementations? happy to take another look after. shout in https://discord.gg/xvNAvMJf if you want to talk it through.

@Jumongweb Jumongweb force-pushed the security-a11y-wallet-createvault-notifications branch from 5568647 to 09e99ff Compare June 27, 2026 20:31
@Jumongweb

Copy link
Copy Markdown
Contributor Author

Rebased onto latest main, kept the lazy jsPDF import, and reworked the create-vault changes on top of current main. The branch is pushed and the PR is updated.

@1nonlypiece

Copy link
Copy Markdown
Contributor

nice, the empty-state placeholder reads much cleaner than bare axes. merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants