feat: date-range and milestone filters for validation history (#282)#508
Open
Favourejiro wants to merge 1 commit into
Open
Conversation
ValidationHistory renders StatusChip -> Tooltip, which calls window.matchMedia. jsdom does not implement it, so the date-range and milestone filter tests (issue Disciplr-Org#282) threw before asserting. Provide a matchMedia stub in the shared test setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #282
date-range and milestone filtering for the verifier
ValidationHistorypage.The filter logic, UI controls, tests, and docs for this feature were in place, but the
ValidationHistorytest suite could not run: the page rendersStatusChip→Tooltip, which callswindow.matchMedia. jsdom does not implementmatchMediaand the shared test setup never mocked it, so every test threw before asserting.This PR adds a
window.matchMediastub tosrc/setupTests.tsso the suite runs.Behavior (per issue requirements)
filterValidationHistoryaccepts optional{ from, to, milestone }.ValidationHistory.tsx.Testing
paginate.test.ts— 21/21 pass (open-ended ranges, inclusive bounds, no-match, combined filters).ValidationHistory.test.tsx— 17/17 pass (date range, milestone, page-1 reset, combined with status/search).matchMediastub strictly reduces pre-existing failures across other Tooltip/Theme-dependent suites.