test: cover NavLink trailing-slash active-state edge cases#509
Open
Favourejiro wants to merge 1 commit into
Open
test: cover NavLink trailing-slash active-state edge cases#509Favourejiro wants to merge 1 commit into
Favourejiro wants to merge 1 commit into
Conversation
Add RTL cases for trailing-slash path differences in NavLink's startsWith-based active logic (issue Disciplr-Org#321): a trailing slash on `to` that the current path lacks stays inactive, and a current path that appends a trailing slash to `to` is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #321
adds RTL coverage for
NavLink's active-state andaria-currentbehaviour.src/components/NavLink.tsxcomputes anactiveclass and setsaria-current="page"fromuseLocation().pathname. This is the primarynavigation affordance, and its active/current logic is exactly the kind of thing that silently breaks on a router upgrade. This PR adds
focused tests for that logic under
MemoryRouter, including the trailing-slash edge cases called out in the issue.What's covered
All tests render
NavLinkinside aMemoryRouterwith controllableinitialEntries:tomatches the current path, the link has theactiveclass andaria-current="page".activeclass is absent andaria-currentis undefined.classNameandariaLabelare forwarded to the rendered link./is active only on the exact/path; non-root links use prefix matching./vaults/123) activates/vaults, while/vaultdoes not activate/vaults.to="/vaults/"with path/vaultsstays inactive; path/vaults/activatesto="/vaults".Testing
npm run test -- src/components/tests/NavLink.test.tsx
✅ 12/12 tests pass. No source changes — test-only, no regressions to navigation highlighting.