test: cover verifier batchApprove/batchReject duplicate & all-unknown id edge cases#511
Open
Dennis-Ritchie1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: cover verifier batchApprove/batchReject duplicate & all-unknown id edge cases
Closes #335
Summary
src/Zustand/Store.ts'sbatchApprove/batchRejectare implemented by callingthe single-task mutators per id via
get(). The store already had tests for thecore batch path (transitions, mixed unknown ids, notes propagation, empty list),
but the duplicate id and all-unknown id edge cases called out in the issue
were not directly verified. This PR adds that coverage.
Changes
duplicate entry in history, and the task lands as
approved.batchApproveandbatchReject(pending queue untouched, history stays empty).Both tests follow the existing pattern: the store is reset between tests via
useVerifierStore.setState(...)inbeforeEach.Testing
npx vitest run src/Zustand/__tests__/Store.test.ts→ 8 tests passing.Store.ts: 100% branch coverage; the verifier batch/single mutators are fullycovered (the only uncovered lines belong to the unrelated notification store).
Notes for reviewer
The core batch tests already exist on
main(from an earlier commit), so this is asmall, focused extension covering the two remaining edge cases from the issue.
The diff is limited to
src/Zustand/__tests__/Store.test.ts.