feat: add reusable VaultFilterBar and filterVaults utility#515
Open
Tboy123-emm wants to merge 2 commits into
Open
feat: add reusable VaultFilterBar and filterVaults utility#515Tboy123-emm wants to merge 2 commits into
Tboy123-emm wants to merge 2 commits into
Conversation
|
@Tboy123-emm Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@GBOYEE has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @GBOYEE to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #275
Introduces a reusable controlled
VaultFilterBarcomponent and a purefilterVaultsutility to eliminate per-page re-implementation of status/search filtering.Changes
src/utils/filterVaults.ts: PurefilterVaults<T extends FilterableVault>(vaults, { status, query })utility. Filters byVaultStatus | 'all'and case-insensitive name query (trims whitespace). Fully generic so it works for both Vaults and Dashboard vault arrays.src/components/VaultFilterBar.tsx: Controlled component acceptingvalue: VaultFiltersandonChange. Status options derived fromVAULT_STATUS_ORDER(single source of truth). Token-styled using CSS variables. Keyboard accessible<select>and<input type="search">. Search landmark withrole="search"andaria-label.src/pages/Vaults.tsx: WiredVaultFilterBarabove the vault list in the data state; filter state managed withuseState<VaultFilters>.src/utils/__tests__/filterVaults.test.ts: 12 test cases covering all/status/query filtering, case-insensitivity, whitespace trimming, empty list, generic types, and all five statuses.src/components/__tests__/VaultFilterBar.test.tsx: 8 test cases covering render, all options, controlled value reflection, onChange for select and input, search landmark, and keyboard accessibility.design-system/documentation/getting-started.md: Added VaultFilterBar section with usage example, props table, and accessibility notes.Test Results
The pre-existing failure in
Vaults.test.tsx > shows data state when vaults existwas already present before this PR (confirmed by running the test on the base commit without these changes).