fix: schema tests for spacing and color tokens#519
Open
Kureszn wants to merge 1 commit into
Open
Conversation
- Add spacing-color-schema.test.ts: validates DTCG dimension leaves, monotonic 8px spacing scale, container token ordering, no unexpected top-level keys, all color leaves pass isValidColorToken, semantic groups and neutral scale have paired light/dark variants - Fix validators.ts: isValidColorToken used truthy guard on .accessibility and .colorblindSimulation, causing null/array/primitive values to bypass validation and return true. Changed to !== undefined checks with explicit Array.isArray guards. - Fix token-loader.test.ts: warn call count was hardcoded to 6 but getAllTokens now loads 7 files (z-index.json was added). Updated expectation to 7.
|
@Kureszn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@GBOYEE has applied to work on this issue as part of the Stellar Wave Program's 6th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @GBOYEE to this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #334