test: add enterprise guard coverage#893
Closed
CleanDev-Fix wants to merge 1 commit into
Closed
Conversation
Contributor
|
appreciate the work, but #858 already has an assignee who isn't you. closing for now — claim an open issue and we'll review that. https://discord.gg/xvNAvMJf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dedicated
enterpriseGuardfeature-gating tests and documents the guard decision matrix.Changes
src/tests/enterpriseGuard.test.tscovering auth-before-authz ordering, enterprise allow/deny behavior, fail-closed tier cases, tier downgrade behavior, andorgAuth/RBAC ordering.docs/enterprise.mdwith the expectedenterpriseGuardoutcomes for missing auth, missing tier, non-enterprise users, valid enterprise users, org membership, and RBAC failures.Testing/Verification
npm test -- src/tests/enterpriseGuard.test.tsnpm test -- src/tests/enterpriseGuard.test.ts --coverage --collectCoverageFrom=src/middleware/enterpriseGuard.tsnpx eslint src/tests/enterpriseGuard.test.ts src/middleware/enterpriseGuard.ts --max-warnings=0npm run buildwas also attempted, but the repository currently has unrelated pre-existing TypeScript errors outside this diff.Closes #858