Skip to content

ENG-1491: Part of the discourse context query settings blocks appears in the page if you select "hide interface" in the discourse context menu at the top of the page #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sid597 merged 5 commits into from
Apr 20, 2026
+110 −100
Merged

ENG-1491: Part of the discourse context query settings blocks appears in the page if you select "hide interface" in the discourse context menu at the top of the page #953

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4efb817
ENG-1491 Hide settings UI in ResultsView when preventSavingSettings i…
sid597 Apr 11, 2026
1b9dff3
void 3 floating promises in ResultsView handlers
sid597 Apr 11, 2026
4b12811
Revert Copy Query hide; keep scope on settings only
sid597 Apr 11, 2026
e2b7394
Forward preventSavingSettings to ResultsTable
sid597 Apr 11, 2026
cee0f68
Guard onDragEnd column-width persistence behind preventSavingSettings
sid597 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
277 changes: 145 additions & 132 deletions apps/roam/src/components/results-view/ResultsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1149,120 +1149,128 @@
}}
/>
)}
<Divider />
<MenuItem
icon={"list"}
text={"Results"}
className={isMenuIconDirty ? "roamjs-item-dirty" : ""}
>
<MenuItem
icon={"layout"}
text={"Layout"}
onClick={() => {
setIsEditLayout(true);
}}
/>
{(!preventSavingSettings || onEdit) && <Divider />}
{!preventSavingSettings && (
<MenuItem
icon={"eye-open"}
text={"Column Views"}
className={isColumnViewsDirty ? "roamjs-item-dirty" : ""}
onClick={() => {
setIsEditViews(true);
}}
/>
<MenuItem
icon={showSearchFilter ? "zoom-out" : "search"}
text={showSearchFilter ? "Hide Search" : "Search"}
className={
searchFilter && !showSearchFilter
? "roamjs-item-dirty"
: ""
}
onClick={() => {
setMoreMenuOpen(false);
setShowSearchFilter((s) => !s);
if (!preventSavingSettings) {
icon={"list"}
text={"Results"}
className={isMenuIconDirty ? "roamjs-item-dirty" : ""}
>
<MenuItem
icon={"layout"}
text={"Layout"}
onClick={() => {
setIsEditLayout(true);
}}
/>
<MenuItem
icon={"eye-open"}
text={"Column Views"}
className={
isColumnViewsDirty ? "roamjs-item-dirty" : ""
}
onClick={() => {
setIsEditViews(true);
}}
/>
<MenuItem
icon={showSearchFilter ? "zoom-out" : "search"}
text={showSearchFilter ? "Hide Search" : "Search"}
className={
searchFilter && !showSearchFilter
? "roamjs-item-dirty"
: ""
}
onClick={() => {
setMoreMenuOpen(false);
setShowSearchFilter((s) => !s);
if (!preventSavingSettings) {
setInputSetting({

Check warning on line 1188 in apps/roam/src/components/results-view/ResultsView.tsx

View workflow job for this annotation

GitHub Actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/results-view/ResultsView.tsx#L1188 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
Raw output 
  1188:29  warning  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
blockUid: settings.resultNodeUid,
key: "showSearchFilter",
value: showSearchFilter ? "hide" : "show",
});
}
}}
/>
<MenuItem
icon={showInputs ? "minus" : "plus"}
text={showInputs ? "Hide Inputs" : "Inputs"}
onClick={() => {
setMoreMenuOpen(false);
setShowInputs(!showInputs);
setInputSetting({
blockUid: settings.resultNodeUid,
key: "showSearchFilter",
value: showSearchFilter ? "hide" : "show",
key: "showInputs",
value: showInputs ? "hide" : "show",
});
}}
/>
<MenuItem
icon={"filter"}
text={"Filters"}
className={
columnFilters.length ? "roamjs-item-dirty" : ""
}
}}
/>
onClick={() => {
setIsEditColumnFilter(true);
}}
/>
<MenuItem
icon={"sort"}
text={"Sort"}
className={activeSort.length ? "roamjs-item-dirty" : ""}
onClick={() => {
setIsEditColumnSort(true);
}}
/>
<MenuItem
icon={"random"}
text={"Get Random"}
className={random.count ? "roamjs-item-dirty" : ""}
onClick={() => setIsEditRandom(true)}
/>
<MenuItem
icon={"numbered-list"}
text={"Rows per page"}
onClick={() => setIsEditPageSize(true)}
/>
</MenuItem>
)}
{!preventSavingSettings && (
<MenuItem
icon={showInputs ? "minus" : "plus"}
text={showInputs ? "Hide Inputs" : "Inputs"}
icon={"tag"}
text={showAlias ? "Hide Alias" : "Alias"}
onClick={() => {
setMoreMenuOpen(false);
setShowInputs(!showInputs);
setInputSetting({
blockUid: settings.resultNodeUid,
key: "showInputs",
value: showInputs ? "hide" : "show",
key: "showAlias",
value: showAlias ? "hide" : "show",
});
setShowAlias(!showAlias);
setMoreMenuOpen(false);
}}
/>
)}
{!preventSavingSettings && (
<MenuItem
icon={"filter"}
text={"Filters"}
className={
columnFilters.length ? "roamjs-item-dirty" : ""
}
onClick={() => {
setIsEditColumnFilter(true);
}}
/>
<MenuItem
icon={"sort"}
text={"Sort"}
className={activeSort.length ? "roamjs-item-dirty" : ""}
icon={showInterface ? "th-disconnect" : "th"}
text={showInterface ? "Hide Interface" : "Show Interface"}
onClick={() => {
setIsEditColumnSort(true);
const resultNode = getSubTree({
key: "results",
parentUid,
});
setInputSetting({

Check warning on line 1264 in apps/roam/src/components/results-view/ResultsView.tsx

View workflow job for this annotation

GitHub Actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/results-view/ResultsView.tsx#L1264 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
Raw output 
  1264:25  warning  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
key: "interface",
value: showInterface ? "hide" : "show",
blockUid: resultNode.uid,
});
setShowInterface((s) => !s);
setMoreMenuOpen(false);
}}
/>
<MenuItem
icon={"random"}
text={"Get Random"}
className={random.count ? "roamjs-item-dirty" : ""}
onClick={() => setIsEditRandom(true)}
/>
<MenuItem
icon={"numbered-list"}
text={"Rows per page"}
onClick={() => setIsEditPageSize(true)}
/>
</MenuItem>
<MenuItem
icon={"tag"}
text={showAlias ? "Hide Alias" : "Alias"}
onClick={() => {
setInputSetting({
blockUid: settings.resultNodeUid,
key: "showAlias",
value: showAlias ? "hide" : "show",
});
setShowAlias(!showAlias);
setMoreMenuOpen(false);
}}
/>
<MenuItem
icon={showInterface ? "th-disconnect" : "th"}
text={showInterface ? "Hide Interface" : "Show Interface"}
onClick={() => {
const resultNode = getSubTree({
key: "results",
parentUid,
});
setInputSetting({
key: "interface",
value: showInterface ? "hide" : "show",
blockUid: resultNode.uid,
});
setShowInterface((s) => !s);
setMoreMenuOpen(false);
}}
/>
)}
Comment thread
sid597 marked this conversation as resolved.
<MenuItem
icon={"export"}
text={"Share Data"}
Expand All @@ -1280,7 +1288,9 @@
setIsExportOpen(true);
}}
/>
<Divider />
{(isEditBlock || !preventSavingSettings || onDeleteQuery) && (
<Divider />
)}
{isEditBlock && (
<MenuItem
icon={"edit"}
Expand All @@ -1300,40 +1310,43 @@
}}
/>
)}
<MenuItem
icon={"clipboard"}
text={"Copy Query"}
onClick={() => {
const getTextFromTreeToPaste = (
items: RoamBasicNode[],
indentLevel = 0,
): string => {
const indentation = " ".repeat(indentLevel);
{!preventSavingSettings && (
<MenuItem
icon={"clipboard"}
text={"Copy Query"}
onClick={() => {
const getTextFromTreeToPaste = (
items: RoamBasicNode[],
indentLevel = 0,
): string => {
const indentation = " ".repeat(indentLevel);

return items
.map((item) => {
const childrenText =
item.children.length > 0
? getTextFromTreeToPaste(
item.children,
indentLevel + 1,
)
: "";
return `${indentation}- ${item.text}\n${childrenText}`;
})
.join("");
};
const tree = getBasicTreeByParentUid(parentUid);
navigator.clipboard.writeText(
"- {{query block}}\n" + getTextFromTreeToPaste(tree, 1),
);
renderToast({
id: "query-copy",
content: "Copied Query",
intent: Intent.PRIMARY,
});
}}
/>
return items
.map((item) => {
const childrenText =
item.children.length > 0
? getTextFromTreeToPaste(
item.children,
indentLevel + 1,
)
: "";
return `${indentation}- ${item.text}\n${childrenText}`;
})
.join("");
};
const tree = getBasicTreeByParentUid(parentUid);
navigator.clipboard.writeText(

Check warning on line 1338 in apps/roam/src/components/results-view/ResultsView.tsx

View workflow job for this annotation

GitHub Actions / eslint (apps/roam)

[eslint (apps/roam)] apps/roam/src/components/results-view/ResultsView.tsx#L1338 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
Raw output 
  1338:25  warning  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator                                                                                         @typescript-eslint/no-floating-promises
"- {{query block}}\n" +
getTextFromTreeToPaste(tree, 1),
);
renderToast({
id: "query-copy",
content: "Copied Query",
intent: Intent.PRIMARY,
});
}}
/>
)}
{onDeleteQuery && (
<>
<MenuItem
Expand Down
Loading