Skip to content

[repo] Fix octal-parsing crash in validate.sh version comparison #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethwv merged 1 commit into from
Jul 25, 2026
Merged

[repo] Fix octal-parsing crash in validate.sh version comparison #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/scripts/validate/validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ version_greater_than() {
local old_version=$2
IFS='.' read -r NEW_MAJOR NEW_MINOR NEW_PATCH <<< "$new_version"
IFS='.' read -r OLD_MAJOR OLD_MINOR OLD_PATCH <<< "$old_version"
if (( NEW_MAJOR > OLD_MAJOR )); then return 0; fi
if (( NEW_MAJOR < OLD_MAJOR )); then return 1; fi
if (( NEW_MINOR > OLD_MINOR )); then return 0; fi
if (( NEW_MINOR < OLD_MINOR )); then return 1; fi
if (( NEW_PATCH > OLD_PATCH )); then return 0; fi
if (( 10#$NEW_MAJOR > 10#$OLD_MAJOR )); then return 0; fi
if (( 10#$NEW_MAJOR < 10#$OLD_MAJOR )); then return 1; fi
if (( 10#$NEW_MINOR > 10#$OLD_MINOR )); then return 0; fi
if (( 10#$NEW_MINOR < 10#$OLD_MINOR )); then return 1; fi
if (( 10#$NEW_PATCH > 10#$OLD_PATCH )); then return 0; fi
return 1
}

Expand Down