fix: respect discriminator mapping in response body mappers#143
Merged
zedorg merged 2 commits intoJun 17, 2026
Merged
Conversation
The generated toSchema() derived the setter and mapper-property names purely from the runtime discriminator value (set.ucfirst(value) and value.'Mapper'), which only worked when the value happened to match its schema name. When a discriminator mapping maps a value to a differently named schema (e.g. interaction -> InteractionRecommendation), the generated setter and mapper property did not exist. Generate an explicit switch from the discriminator mapping, resolving each mapping value to its oneOf/anyOf child field and emitting that child's real setter and mapper property. The default arm keeps the previous value-based dispatch as the implicit-naming fallback for discriminators without a mapping.
tamastoth-byborg
approved these changes
Jun 17, 2026
zedorg
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated toSchema() derived the setter and mapper-property names purely from the runtime discriminator value (set.ucfirst(value) and value.'Mapper'), which only worked when the value happened to match its schema name. When a discriminator mapping maps a value to a differently named schema (e.g. animal -> AnimalResponse), the generated setter and mapper property did not exist.
Generate an explicit switch from the discriminator mapping, resolving each mapping value to its oneOf/anyOf child field and emitting that child's real setter and mapper property. The default arm keeps the previous value-based dispatch as the implicit-naming fallback for discriminators without a mapping.