feat(dstackup): support configurable release API#805
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configurable “GitHub-compatible Releases API base URL” to dstackup, so both dstackup image pull and install-time automatic image downloads can be exercised against an HTTP proxy or local test server. It also introduces a small local overlay server to publish/serve release assets while relaying cache misses to the real GitHub API, plus documentation for the workflow.
Changes:
- Add global
--release-api-base-urland thread it throughinstallandimage pullrelease lookups. - Update release-lookup URL construction to use the configured API base (including new unit test coverage for trailing slash handling).
- Add
tools/mock-github-releases.pyand a doc guide for locally publishing and pulling test releases.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/mock-github-releases.py | New local GitHub Releases API overlay for publishing local assets and relaying upstream requests. |
| dstack/crates/dstackup/src/main.rs | Plumbs the global release API base URL into install and image subcommands. |
| dstack/crates/dstackup/src/install.rs | Passes the release API base URL into install-time image resolution/pull logic. |
| dstack/crates/dstackup/src/image.rs | Uses the configured base URL for tagged/latest release API calls and extends tests. |
| dstack/crates/dstackup/src/cli.rs | Introduces the global --release-api-base-url flag and default value. |
| docs/testing-dstackup-image-pull.md | Documents running the mock server, publishing a local release, and pulling via the custom base URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--release-api-base-urloption used by bothdstackup image pulland install-time automatic image downloadsTesting
cargo fmt --checkcargo test -p dstackup --quietpython3 -m py_compile tools/mock-github-releases.py